From: Joshua Brindle <jbrindle@tresys.com>
To: Ivan Gyurdiev <ivg2@cornell.edu>
Cc: SELinux List <SELinux@tycho.nsa.gov>,
Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [SEMANAGE] Swig update: typemaps
Date: Mon, 02 Jan 2006 15:33:08 -0500 [thread overview]
Message-ID: <43B98E04.1060609@tresys.com> (raw)
In-Reply-To: <43B9712C.1080402@cornell.edu>
Ivan Gyurdiev wrote:
>>
>>>
>>>
>>> Have to be careful with this one, you don't want it messing with
>>> other char**. Did you run all the tests in pywrap-test after
>>> rebuilding this to make sure it didn't interrupt anything else?
>>>
>>> The rest look fine.
>>>
>>
>> Speaking of which. Anytime you add anything to the wrapper please add
>> the corresponding tests to pywrap-test. I'd like it if there was
>> always a test for anything in mainline (I think Steve would too)
>
>
> I have my own set of tests in C that I run (with valgrind). They're
> probably more detailed than what you have, but in terms of code are an
> awful mess, so I can't really submit them to use.
>
That is fine but there should be tests for the wrappers upstream. I
consider this a requirement for adding wrappers.
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
prev parent reply other threads:[~2006-01-02 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-25 20:55 [SEMANAGE] Swig update: typemaps Ivan Gyurdiev
2006-01-02 19:06 ` Joshua Brindle
2006-01-02 19:58 ` Joshua Brindle
2006-01-02 18:30 ` Ivan Gyurdiev
2006-01-02 20:33 ` Joshua Brindle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43B98E04.1060609@tresys.com \
--to=jbrindle@tresys.com \
--cc=SELinux@tycho.nsa.gov \
--cc=ivg2@cornell.edu \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.