From: Ivan Gyurdiev <ivg2@cornell.edu>
To: SELinux List <SELinux@tycho.nsa.gov>
Cc: Daniel J Walsh <dwalsh@redhat.com>,
Joshua Brindle <jbrindle@tresys.com>,
Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [SEMANAGE] [SETSEBOOL] Clone record on set/add/modify
Date: Wed, 04 Jan 2006 14:22:54 -0500 [thread overview]
Message-ID: <43BC208E.7020905@cornell.edu> (raw)
In-Reply-To: <43BC1EE4.3040603@cornell.edu>
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
> Well, the add function is broken, as you noted in your other mail, but
> why it crashes I have no idea.
Here's a patch to fix the add function. Typically I test modify and
assume add/set work - they're mostly the same.
I guess assumptions are a bad thing. Before Joshua says "I told you so"
- I will update pywrap-test.py by tomorrow.
Now I'm curious to investigate the segfault - that should most
definitely *not* happen.
[-- Attachment #2: libsemanage.toggle_modify.diff --]
[-- Type: text/x-patch, Size: 456 bytes --]
diff -Naurp --exclude man --exclude-from excludes old/libsemanage/src/database_llist.c new/libsemanage/src/database_llist.c
--- old/libsemanage/src/database_llist.c 2006-01-04 12:18:17.000000000 -0500
+++ new/libsemanage/src/database_llist.c 2006-01-04 14:16:49.000000000 -0500
@@ -136,6 +136,7 @@ hidden int dbase_llist_add(
if (dbase_llist_cache_prepend(handle, dbase, data) < 0)
goto err;
+ dbase->modified = 1;
return STATUS_SUCCESS;
err:
next prev parent reply other threads:[~2006-01-04 19:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-04 14:08 [SEMANAGE] [SETSEBOOL] Clone record on set/add/modify Ivan Gyurdiev
2006-01-04 14:09 ` Ivan Gyurdiev
2006-01-04 17:29 ` Stephen Smalley
2006-01-04 16:12 ` Ivan Gyurdiev
2006-01-04 18:24 ` Stephen Smalley
2006-01-04 16:49 ` Ivan Gyurdiev
[not found] ` <43BC3715.7030803@redhat.com>
[not found] ` <43BC1EE4.3040603@cornell.edu>
2006-01-04 19:22 ` Ivan Gyurdiev [this message]
2006-01-04 17:59 ` Joshua Brindle
2006-01-04 16:06 ` Ivan Gyurdiev
2006-01-04 18:05 ` Joshua Brindle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43BC208E.7020905@cornell.edu \
--to=ivg2@cornell.edu \
--cc=SELinux@tycho.nsa.gov \
--cc=dwalsh@redhat.com \
--cc=jbrindle@tresys.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.