All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: Tony Lindgren <tony@atomide.com>, Petukhov Nikolay <palmtt2@mail.ru>
Cc: linux-omap-open-source@linux.omap.com
Subject: [PATCH] Re: omap1510 MPU interupt BUG
Date: Fri, 06 Jan 2006 20:37:25 +0100	[thread overview]
Message-ID: <43BEC6F5.70504@de.bosch.com> (raw)
In-Reply-To: <20060103175520.GO6034@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

Tony Lindgren wrote:

>>diff -Nru linux-2.6.14-omap2/arch/arm/plat-omap/gpio.c
>>linux-2.6.14-omap2-palmtt2/arch/arm/plat-omap/gpio.c  
>>
>>--- linux-2.6.14-omap2/arch/arm/plat-omap/gpio.c        Sat Dec 10 21:05:46 2005      
>>+++ linux-2.6.14-omap2-palmtt2/arch/arm/plat-omap/gpio.c        Sat Dec 10 19:57:30 2005      
>>@@ -758,6 +758,10 @@
>>    
>>while(1) {            
>>isr = __raw_readl(isr_reg);
>>+#ifdef CONFIG_ARCH_OMAP15XX   
>>+       if (bank->method == METHOD_MPUIO)
>>+           isr&=0xffff;   
>>+#endif !
>>
>>_enable_gpio_irqbank(bank, isr, 0);
>>_clear_gpio_irqbank(bank, isr);            
>>_enable_gpio_irqbank(bank, isr, 1);
> 
> 
> Can't read this patch because of the bad formatting... Can you please
> repost? Maybe sending it as an attachment works better with a web
> interface :)

arch/arm/plat-omap/gpio.c has changed since 2.6.14-omap2, so patch above
will not apply to recent git even if formatting is correct. I tried to
adapt it to current version of gpio.c. I can't test it, so is patch
below okay?



[-- Attachment #2: omap1510_mpu_interrupt_bug.patch --]
[-- Type: text/plain, Size: 522 bytes --]

--- ./arch/arm/plat-omap/gpio.c_orig	2006-01-06 19:37:32.602154520 +0100
+++ ./arch/arm/plat-omap/gpio.c	2006-01-06 19:44:03.917665520 +0100
@@ -767,6 +767,9 @@ static void gpio_irq_handler(unsigned in
 					OMAP24XX_GPIO_LEVELDETECT0) |
 				__raw_readl(bank->base +
 					OMAP24XX_GPIO_LEVELDETECT1);
+		if(cpu_is_omap15xx())
+			if(bank->method == METHOD_MPUIO)
+				level_mask = 0xffff0000; 
 
 		/* clear edge sensitive interrupts before handler(s) are
 		called so that we don't miss any interrupt occurred while




[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2006-01-06 19:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-12 16:25 omap1510 MPU interupt BUG Petukhov Nikolay
2006-01-03 17:55 ` Tony Lindgren
2006-01-06 19:37   ` Dirk Behme [this message]
2006-01-16  8:28     ` [PATCH] " palmtt2
2006-01-20 18:43       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43BEC6F5.70504@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=palmtt2@mail.ru \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.