From: Brian Gerst <bgerst@didntduck.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] Clean up asm-offsets.h creation
Date: Fri, 06 Jan 2006 18:28:45 -0500 [thread overview]
Message-ID: <43BEFD2D.8060102@didntduck.org> (raw)
- Move mkdir out of cmd_offsets
- Add input file to sed command instead of using cat
Signed-off-by: Brian Gerst <bgerst@didntduck.org>
---
commit 5976879aa5546beb50cd88ff1ba1d856445b2bad
tree 3af1bc8f50c8efe446fcc67efe312972bcfa731a
parent bcefe96417edca37a3834ba081bc8928cf411183
author Brian Gerst <bgerst@didntduck.org> Fri, 06 Jan 2006 18:27:07 -0500
committer Brian Gerst <bgerst@didntduck.org> Fri, 06 Jan 2006 18:27:07 -0500
Kbuild | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Kbuild b/Kbuild
index 7900391..95d6a00 100644
--- a/Kbuild
+++ b/Kbuild
@@ -22,8 +22,6 @@ sed-$(CONFIG_MIPS) := "/^@@@/s///p"
quiet_cmd_offsets = GEN $@
define cmd_offsets
- mkdir -p $(dir $@); \
- cat $< | \
(set -e; \
echo "#ifndef __ASM_OFFSETS_H__"; \
echo "#define __ASM_OFFSETS_H__"; \
@@ -34,7 +32,7 @@ define cmd_offsets
echo " *"; \
echo " */"; \
echo ""; \
- sed -ne $(sed-y); \
+ sed -ne $(sed-y) $<; \
echo ""; \
echo "#endif" ) > $@
endef
@@ -45,5 +43,6 @@ arch/$(ARCH)/kernel/asm-offsets.s: arch/
$(call if_changed_dep,cc_s_c)
$(obj)/$(offsets-file): arch/$(ARCH)/kernel/asm-offsets.s Kbuild
+ $(Q)mkdir -p $(dir $@)
$(call cmd,offsets)
reply other threads:[~2006-01-06 23:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43BEFD2D.8060102@didntduck.org \
--to=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.