From: Douglas Gilbert <dougg@torque.net>
To: Christoph Hellwig <hch@lst.de>
Cc: jejb@steeleye.com, michaelc@cs.wisc.edu, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] always handle REQ_BLOCK_PC requests in common code
Date: Sat, 07 Jan 2006 16:26:43 +1000 [thread overview]
Message-ID: <43BF5F23.2040804@torque.net> (raw)
In-Reply-To: <20060106173407.GA23658@lst.de>
Christoph Hellwig wrote:
> LLDDs should never see REQ_BLOCK_PC requests, we can handle them just
> fine in the core code. There is a small behaviour change in that some
> check in sr's rw_intr are bypassed, but I consider the old behaviour
> a bug.
>
> Mike found this cleanup ooportunity and provdided early patches, so all
> the credit goes to him, even if I redid the patches from scratch beause
> that was easier than forward-porting the old patches.
The point of the hacks in the sd driver was to make
sure SG_IO ioctl commands issued via a sd device node
would not get caught up in the sd driver's error
processing (e.g. retries on MEDIUM ERRORs). Is there
a clean path back for such errors to the SG_IO ioctl
and hence the user space?
The same applies to most of the error processing done
in the midlayer, with TASK SET FULL being a bit of a
grey area.
Doug Gilbert
next prev parent reply other threads:[~2006-01-07 6:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 17:34 [PATCH] always handle REQ_BLOCK_PC requests in common code Christoph Hellwig
2006-01-07 6:26 ` Douglas Gilbert [this message]
2006-01-07 14:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43BF5F23.2040804@torque.net \
--to=dougg@torque.net \
--cc=hch@lst.de \
--cc=jejb@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.