From: Patrick McHardy <kaber@trash.net>
To: Harald Welte <laforge@netfilter.org>
Cc: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH] x_tables, take 5 (Final Review)
Date: Sun, 08 Jan 2006 23:12:32 +0100 [thread overview]
Message-ID: <43C18E50.5060908@trash.net> (raw)
In-Reply-To: <43C18D77.501@trash.net>
Patrick McHardy wrote:
> For now just one question, I need some time to read through the patch:
>
> static int
> icmp6_checkentry(const char *tablename,
> - const struct ip6t_ip6 *ipv6,
> + const void *entry,
>
> Why do you change struct ip6t_ip6 * to void * for IPv6 matches,
> but keep ipt_ip for IPv4 matches? Shouldn't the old API be
> unaffected by moving some matches and targets to x_tables?
OK, I answered the question myself. I somehow misread and missed
that IPv4 matches are changed too and ipt_register_match is just
a wrapper for xt_tables. Now I like the patch even better :)
next prev parent reply other threads:[~2006-01-08 22:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 21:26 [PATCH] x_tables, take 5 (Final Review) Harald Welte
2006-01-08 22:08 ` Patrick McHardy
2006-01-08 22:12 ` Patrick McHardy [this message]
2006-01-08 23:01 ` Patrick McHardy
2006-01-09 9:19 ` Harald Welte
2006-01-09 6:46 ` Patrick McHardy
2006-01-09 8:59 ` Harald Welte
2006-01-09 8:52 ` Yasuyuki KOZAKAI
[not found] ` <200601090852.k098qjeO004027@toshiba.co.jp>
2006-01-09 10:35 ` Harald Welte
2006-01-10 4:18 ` Yasuyuki KOZAKAI
[not found] ` <200601100418.k0A4IxhL008706@toshiba.co.jp>
2006-01-12 16:58 ` Harald Welte
2006-01-09 11:23 ` Eric Dumazet
2006-01-09 13:15 ` Harald Welte
2006-01-27 15:16 ` [PATCH] x_tables : Use SMP friendly (percpu) rwlock_t to protect x_tables Eric Dumazet
2006-01-27 15:37 ` Stephen Hemminger
2006-01-27 15:46 ` Eric Dumazet
2006-01-27 17:53 ` Stephen Hemminger
2006-01-27 21:51 ` Eric Dumazet
2006-01-27 16:06 ` Eric Dumazet
2006-01-09 17:44 ` [PATCH] x_tables, take 5 (Final Review) Yasuyuki KOZAKAI
[not found] ` <200601091744.k09HiVP2022456@toshiba.co.jp>
2006-01-12 16:02 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C18E50.5060908@trash.net \
--to=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.