From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Mahoney Date: Mon, 09 Jan 2006 17:42:59 +0000 Subject: Re: [PATCH] ia64: including alone causes compilation Message-Id: <43C2A0A3.8070901@suse.com> List-Id: References: <20060109171514.GA25096@locomotive.unixthugs.org> <20060109172149.GQ19769@parisc-linux.org> In-Reply-To: <20060109172149.GQ19769@parisc-linux.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Wilcox Cc: linux-ia64@vger.kernel.org, Linux Kernel Mailing List -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Matthew Wilcox wrote: > On Mon, Jan 09, 2006 at 12:15:14PM -0500, Jeff Mahoney wrote: >> +++ linux-2.6.15-ocfs2/include/asm-ia64/signal.h 2006-01-09 11:08:16.404700640 -0500 >> @@ -1,6 +1,8 @@ >> #ifndef _ASM_IA64_SIGNAL_H >> #define _ASM_IA64_SIGNAL_H >> >> +#include >> + >> /* >> * Modified 1998-2001, 2003 >> * David Mosberger-Tang , Hewlett-Packard Co >> @@ -122,8 +124,6 @@ >> >> # ifndef __ASSEMBLY__ >> >> -# include >> - >> /* Avoid too many header ordering problems. */ >> struct siginfo; > > Is it still possible to include this file from assembly? Do we still > need to do that? > > Yes, actually, it is. :( Christoph also pointed out that including is the better solution, so I'm submitting that patch to the OCFS2 folks instead. Sorry for the noise. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDwqCjLPWxlyuTD7IRAj8PAJwLv2EghfMR9yPuaVhpTLQMGysKpwCfcVBq 7ZT0LwuYEjKYVnJT/QeXmCw=Yt8o -----END PGP SIGNATURE----- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750880AbWAIRjG (ORCPT ); Mon, 9 Jan 2006 12:39:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964889AbWAIRjF (ORCPT ); Mon, 9 Jan 2006 12:39:05 -0500 Received: from locomotive.csh.rit.edu ([129.21.60.149]:29014 "EHLO locomotive.unixthugs.org") by vger.kernel.org with ESMTP id S1750880AbWAIRjE (ORCPT ); Mon, 9 Jan 2006 12:39:04 -0500 Message-ID: <43C2A0A3.8070901@suse.com> Date: Mon, 09 Jan 2006 12:42:59 -0500 From: Jeff Mahoney User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050715) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Matthew Wilcox Cc: linux-ia64@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] ia64: including alone causes compilation errors References: <20060109171514.GA25096@locomotive.unixthugs.org> <20060109172149.GQ19769@parisc-linux.org> In-Reply-To: <20060109172149.GQ19769@parisc-linux.org> X-Enigmail-Version: 0.92.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Matthew Wilcox wrote: > On Mon, Jan 09, 2006 at 12:15:14PM -0500, Jeff Mahoney wrote: >> +++ linux-2.6.15-ocfs2/include/asm-ia64/signal.h 2006-01-09 11:08:16.404700640 -0500 >> @@ -1,6 +1,8 @@ >> #ifndef _ASM_IA64_SIGNAL_H >> #define _ASM_IA64_SIGNAL_H >> >> +#include >> + >> /* >> * Modified 1998-2001, 2003 >> * David Mosberger-Tang , Hewlett-Packard Co >> @@ -122,8 +124,6 @@ >> >> # ifndef __ASSEMBLY__ >> >> -# include >> - >> /* Avoid too many header ordering problems. */ >> struct siginfo; > > Is it still possible to include this file from assembly? Do we still > need to do that? > > Yes, actually, it is. :( Christoph also pointed out that including is the better solution, so I'm submitting that patch to the OCFS2 folks instead. Sorry for the noise. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDwqCjLPWxlyuTD7IRAj8PAJwLv2EghfMR9yPuaVhpTLQMGysKpwCfcVBq 7ZT0LwuYEjKYVnJT/QeXmCw= =Yt8o -----END PGP SIGNATURE-----