From: Paulo Marques <pmarques@grupopie.com>
To: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
akpm@osdl.org, tony.luck@intel.com,
Systemtap <systemtap@sources.redhat.com>,
Jim Keniston <jkenisto@us.ibm.com>, Keith Owens <kaos@sgi.com>
Subject: Re: [patch 1/2] [BUG]kallsyms_lookup_name should return the text addres
Date: Tue, 10 Jan 2006 20:45:02 +0000 [thread overview]
Message-ID: <43C41CCE.8070208@grupopie.com> (raw)
In-Reply-To: <20060110204045.712982192@csdlinux-2.jf.intel.com>
Anil S Keshavamurthy wrote:
> [...]
> The bug is kallsyms_lookup_name() -> module_kallsyms_lookup_name(mod, name)
> search the name in the given module and returns the address when
> name is matched. This address very well could be the address of 'U' type
> which is different address than 't' type.
> [...]
> for (i = 0; i < mod->num_symtab; i++)
> - if (strcmp(name, mod->strtab+mod->symtab[i].st_name) == 0)
> + if ((strcmp(name, mod->strtab+mod->symtab[i].st_name) == 0) &&
> + (mod->symtab[i].st_info == 't'))
This conflicts with a similar patch from Keith Owens earlier this week.
In his patch he did "mod->symtab[i].st_info != 'U'" instead of
"mod->symtab[i].st_info == 't'".
I actually prefer Keith's version as it is the one which solves the bug
by changing as least as possible the current behavior.
--
Paulo Marques - www.grupopie.com
Pointy-Haired Boss: I don't see anything that could stand in our way.
Dilbert: Sanity? Reality? The laws of physics?
next prev parent reply other threads:[~2006-01-10 20:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 20:39 kallsyms_lookup_name should return the text addres Anil S Keshavamurthy
2006-01-10 20:39 ` [patch 1/2] [BUG]kallsyms_lookup_name " Anil S Keshavamurthy
2006-01-10 20:45 ` Paulo Marques [this message]
2006-01-10 21:07 ` Keshavamurthy Anil S
2006-01-10 23:11 ` Keith Owens
2006-01-10 23:29 ` Keshavamurthy Anil S
2006-01-11 0:02 ` Keith Owens
2006-01-11 0:07 ` Randy.Dunlap
2006-01-11 0:23 ` Keith Owens
2006-01-11 0:39 ` Keshavamurthy Anil S
2006-01-11 2:26 ` Frank Ch. Eigler
2006-01-10 20:39 ` [patch 2/2] Link new module to the tail of module list Anil S Keshavamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C41CCE.8070208@grupopie.com \
--to=pmarques@grupopie.com \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=jkenisto@us.ibm.com \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=systemtap@sources.redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.