From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Diestelhorst Subject: Re: [PATCH] Getting and setting SEDF scheduling parameters Date: Thu, 12 Jan 2006 08:29:54 +0100 Message-ID: <43C60572.3080803@cam.ac.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: John L Griffin Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org John L Griffin wrote: >This patch addresses three problems in the function sedf_adjdom(): > >3) The code logic in this function is cryptic, and there is not much >documentation on how the scheduling parameters should be used. The >attached patch adds comments to the sedf_adjdom() function, and >reorders/rewrites the logic of the SCHED_INFO_PUT handling to make the >code more self-documenting. > > I know, the main problem is, that there are quite a number of different interpretations for some of the values, depending on the others. This caused some cryptic code as you point out properly, which I wasn't really happy with! Stephan >Note that this patch makes strong assumptions about how the scheduling >parameters are used. So, I recommend someone take a really close look at >my comments to make sure I've preserved the Xen team's intentions for how >the SEDF scheduler works. :-) > >Signed-off-by: jlg@us.ibm.com > > > >------------------------------------------------------------------------ > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel > >