From: Jiri Slaby <slaby@liberouter.org>
To: Jon Mason <jdmason@us.ibm.com>
Cc: mulix@mulix.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Prevent trident driver from grabbing pcnet32 hardware
Date: Thu, 12 Jan 2006 20:28:30 +0100 [thread overview]
Message-ID: <43C6ADDE.5060904@liberouter.org> (raw)
In-Reply-To: <20060112175051.GA17539@us.ibm.com>
Jon Mason napsal(a):
> Some pcnet32 hardware erroneously has the Vendor ID for Trident. The
> pcnet32 driver looks for the PCI ethernet class before grabbing the
> hardware, but the current trident driver does not check against the
> PCI audio class. This allows the trident driver to claim the pcnet32
> hardware. This patch prevents that.
>
> This patch is untested on Trident 4DWAVE_DX hardware, but has been
> tested on pcnet32 hardware.
>
> Thanks,
> Jon
>
> Signed-off-by: Jon Mason <jdmason@us.ibm.com>
>
> diff -r 4a7597b41d25 sound/oss/trident.c
> --- a/sound/oss/trident.c Wed Jan 11 19:14:08 2006
> +++ b/sound/oss/trident.c Thu Jan 12 11:32:26 2006
You should change alsa driver (sound/pci/trident/trident.c), rather than this,
which will be removed soon, I guess. And, additionally, could you change that
lines to use PCI_DEVICE macro?
regards,
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@gmail.com ~\-/~
B67499670407CE62ACC8 22A032CC55C339D47A7E
next prev parent reply other threads:[~2006-01-12 19:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 17:50 [PATCH] Prevent trident driver from grabbing pcnet32 hardware Jon Mason
2006-01-12 19:28 ` Jiri Slaby [this message]
2006-01-12 19:34 ` Jiri Slaby
2006-01-12 20:07 ` Muli Ben-Yehuda
2006-01-12 21:15 ` Lee Revell
2006-01-12 21:58 ` Adrian Bunk
2006-01-12 22:06 ` Lee Revell
2006-01-12 22:11 ` Jon Mason
2006-01-12 22:46 ` Adrian Bunk
2006-01-12 21:47 ` Jon Mason
2006-01-12 22:00 ` Adrian Bunk
2006-01-12 22:09 ` Jan Engelhardt
2006-01-12 22:20 ` Jon Mason
2006-01-12 22:42 ` Lee Revell
2006-01-12 22:52 ` Adrian Bunk
2006-01-12 22:55 ` Lee Revell
2006-01-13 10:16 ` Alan Cox
2006-01-12 23:32 ` Old hardware (was Re: [PATCH] Prevent trident driver from grabbing pcnet32 hardware) Lee Revell
2006-01-12 23:52 ` Bob Copeland
2006-01-13 10:28 ` [PATCH] Prevent trident driver from grabbing pcnet32 hardware Alan Cox
2006-01-13 17:55 ` Lee Revell
2006-01-13 11:37 ` Muli Ben-Yehuda
2006-01-13 12:23 ` Adrian Bunk
2006-01-13 12:32 ` Muli Ben-Yehuda
2006-01-13 15:24 ` Adrian Bunk
2006-01-13 15:36 ` Muli Ben-Yehuda
2006-01-12 22:08 ` Jon Mason
2006-01-12 20:49 ` pcnet32 devices with incorrect trident vendor ID Daniel Drake
2006-01-12 20:57 ` Matthew Wilcox
2006-01-12 21:03 ` Daniel Drake
2006-01-12 21:05 ` Matthew Wilcox
2006-01-12 21:22 ` Bill Nottingham
2006-01-12 21:24 ` Bill Nottingham
2006-01-12 22:23 ` Don Fry
2006-01-12 22:33 ` Jon Mason
2006-01-12 21:05 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C6ADDE.5060904@liberouter.org \
--to=slaby@liberouter.org \
--cc=jdmason@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mulix@mulix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.