Re: [KJ] Audit return codes (and handle failure correctly)

[Christophe Lucas <clucas@altern.org>]

Alexey Dobriyan a écrit :

>On Sun, Jan 15, 2006 at 05:31:05PM +0200, Udayan Singh wrote:
>  
>
>>I am trying to understand a point mentioned in ToDo list of KJ,
>>
>>"Audit return codes (and handle failure correctly) for  " -- create_proc_*()
>>..
>>
>>I had a look at the code (in fs/proc/*, linux kernel 2.6.14).
>>
>>Clarifications that i needed :
>>
>>Is it that the wherever create_proc_* functions are being called, it needs
>>to be looked into how is it handling a failure ?
>>OR
>>Within the function(s) create_proc_*, it needs to be looked into for the
>>error codes it is receiving while it is calling other functions and handle
>>them accordingly ?
>>    
>>
>
>The former. If function can fail its return code should be checked,
>except very rare cases where you can't do anything better than panic().
>
>  
>
>>I intend to understand the above mentioned requirement and then try to do
>>it. Would appreciate information on above.
>>    
>>
>
>Be sure to grab latest kernel (2.6.16-rc1 should be out pretty soon) and
>look at latest -kj for things already done.
>  
>
Hi all,

I think you could search on :
    http://coderock.org/kj/2.6.13-rc1-kj/split/
and :
    
http://coderock.org/kj/2.6.13-rc1-kj/split/return_code-drivers_net_tokenring_olympic
could be a good start...

Have a nice day,
 

			 - Christophe (clucas@altern.org) [At home]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors