All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylylov <sshtylyov@ru.mvista.com>
To: Linux MIPS <linux-mips@linux-mips.org>
Cc: Manish Lachwani <mlachwani@mvista.com>,
	Jordan Crouse <jordan.crouse@amd.com>
Subject: [PATCH] Au1xx0: really set KSEG0 to uncached on reboot
Date: Tue, 17 Jan 2006 21:54:38 +0300	[thread overview]
Message-ID: <43CD3D6E.9040004@ru.mvista.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Hello.

    Just found really old buglet in AMD Au1xx0 restart code: instead of
modifying the whole CP0 Config.K0 field to 010b (meaning KSEG0 uncached) 
before flushing the caches and resetting a board, it only sets bit 1 of that 
reg. which is effectively a NOP since Config.K0 == 011b as the kernel sets it 
up (which is also its default value for Au1xx0).

WBR, Sergei


[-- Attachment #2: Au1xx0-make-KSEG0-uncached-on-reboot.patch --]
[-- Type: text/plain, Size: 415 bytes --]

diff --git a/arch/mips/au1000/common/reset.c b/arch/mips/au1000/common/reset.c
index 65b84db..4ffcced 100644
--- a/arch/mips/au1000/common/reset.c
+++ b/arch/mips/au1000/common/reset.c
@@ -151,7 +151,7 @@ void au1000_restart(char *command)
 	}
 
 	set_c0_status(ST0_BEV | ST0_ERL);
-	set_c0_config(CONF_CM_UNCACHED);
+	change_c0_config(CONF_CM_CMASK, CONF_CM_UNCACHED);
 	flush_cache_all();
 	write_c0_wired(0);
 


             reply	other threads:[~2006-01-17 18:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-17 18:54 Sergei Shtylylov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-01-25 18:27 [PATCH] Au1xx0: really set KSEG0 to uncached on reboot Sergei Shtylylov
2006-01-30 14:10 David Sanchez
2006-01-30 14:10 ` David Sanchez
2006-02-04  0:25 ` Sergei Shtylylov
2006-02-06  8:10 David Sanchez
2006-02-06  8:10 ` David Sanchez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43CD3D6E.9040004@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=jordan.crouse@amd.com \
    --cc=linux-mips@linux-mips.org \
    --cc=mlachwani@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.