Re: Latest policycoreutils patch

[Daniel J Walsh <dwalsh@redhat.com>]

Ivan Gyurdiev wrote:
>
>> Not sure I follow; the patch changes some occurrences of "Failed to add
>> port" to "Failed to modify port" in the add() method.
>>   
> ...which is wrong, imho, it should still say "Failed to add port".
> The second part of it is right, I think (I assume it's changing 
> modify(), hard to tell without the -p flag).
> There's a bug in modify that says "failed to add" currently.
>
> I agree with what Dan is saying, I just think the first place he's 
> changing is wrong.
>
Yes the first part of the patch is wrong.  The messsage under the add 
section should stay add.  I was changing the "add" to "modify" under the 
modify section and got carried away...
> There's another wrong message btw, see interfaces.modify().
>


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.