From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org, albertcc@tw.ibm.com
Subject: Re: [PATCH 04/12] libata: add detailed AC_ERR_* flags
Date: Sun, 22 Jan 2006 04:30:26 -0500 [thread overview]
Message-ID: <43D350B2.3020009@pobox.com> (raw)
In-Reply-To: <11379167101842-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> Add detailed AC_ERR_* flags and use them. Long-term goal is to
> describe all errors with err_mask and tf combination (tf for failed
> sector information, etc...). After proper error diagnosis is
> implemented, sense data should also be generated from err_mask instead
> of directly from hardware tf registers as it is currently.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> ---
>
> drivers/scsi/ahci.c | 6 ++----
> drivers/scsi/libata-core.c | 12 ++++++------
> drivers/scsi/sata_mv.c | 2 +-
> drivers/scsi/sata_sil24.c | 2 +-
> include/linux/libata.h | 15 ++++++++++-----
> 5 files changed, 20 insertions(+), 17 deletions(-)
>
> 1939435a8f0e7b2b1578b84cedd49f8adcab1ea9
> diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c
> index 30676b0..e7b937b 100644
> --- a/drivers/scsi/ahci.c
> +++ b/drivers/scsi/ahci.c
> @@ -680,7 +680,7 @@ static void ahci_eng_timeout(struct ata_
> * not being called from the SCSI EH.
> */
> qc->scsidone = scsi_finish_command;
> - qc->err_mask |= AC_ERR_OTHER;
> + qc->err_mask |= AC_ERR_TIMEOUT;
> ata_qc_complete(qc);
> }
>
> @@ -720,10 +720,8 @@ static inline int ahci_host_intr(struct
> /* command processing has stopped due to error; restart */
> ahci_restart_port(ap, status);
>
> - if (qc) {
> - qc->err_mask |= AC_ERR_OTHER;
> + if (qc)
> ata_qc_complete(qc);
> - }
why are you erasing the error mask here?
> diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
> index 43a2328..f5519f0 100644
> --- a/drivers/scsi/libata-core.c
> +++ b/drivers/scsi/libata-core.c
> @@ -1142,7 +1142,7 @@ ata_exec_internal(struct ata_port *ap, s
> * spurious interrupt. We can live with that.
> */
> if (qc->flags & ATA_QCFLAG_ACTIVE) {
> - qc->err_mask = AC_ERR_OTHER;
> + qc->err_mask = AC_ERR_TIMEOUT;
> ata_qc_complete(qc);
> printk(KERN_WARNING "ata%u: qc timeout (cmd 0x%x)\n",
> ap->id, command);
> @@ -2917,7 +2917,7 @@ static unsigned long ata_pio_poll(struct
> status = ata_chk_status(ap);
> if (status & ATA_BUSY) {
> if (time_after(jiffies, ap->pio_task_timeout)) {
> - qc->err_mask |= AC_ERR_ATA_BUS;
> + qc->err_mask |= AC_ERR_TIMEOUT;
> ap->hsm_task_state = HSM_ST_TMOUT;
> return 0;
> }
perhaps you want to set both flags? If BSY is stuck on, that's a
problem with the ATA bus.
> @@ -4159,14 +4159,14 @@ static void atapi_packet_task(void *_dat
> /* sleep-wait for BSY to clear */
> DPRINTK("busy wait\n");
> if (ata_busy_sleep(ap, ATA_TMOUT_CDB_QUICK, ATA_TMOUT_CDB)) {
> - qc->err_mask |= AC_ERR_ATA_BUS;
> + qc->err_mask |= AC_ERR_TIMEOUT;
> goto err_out;
> }
ditto
next prev parent reply other threads:[~2006-01-22 9:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-22 7:58 [PATCHSET] libata: various fixes related to EH Tejun Heo
2006-01-22 7:58 ` [PATCH 04/12] libata: add detailed AC_ERR_* flags Tejun Heo
2006-01-22 9:30 ` Jeff Garzik [this message]
2006-01-22 9:46 ` Tejun Heo
2006-01-22 9:50 ` Tejun Heo
2006-01-22 7:58 ` [PATCH 02/12] libata: make the owner of a qc responsible for freeing it Tejun Heo
2006-01-22 9:37 ` Jeff Garzik
2006-01-22 10:16 ` Tejun Heo
2006-01-22 7:58 ` [PATCH 01/12] libata: fold __ata_qc_complete() into ata_qc_free() Tejun Heo
2006-01-22 7:58 ` [PATCH 06/12] SCSI: export scsi_eh_finish_cmd() and scsi_eh_flush_done_q() Tejun Heo
2006-01-22 9:36 ` Jeff Garzik
2006-01-22 7:58 ` [PATCH 03/12] libata: fix ata_qc_issue() error handling Tejun Heo
2006-01-22 9:25 ` Jeff Garzik
2006-01-22 7:58 ` [PATCH 05/12] libata: return AC_ERR_* from issue functions Tejun Heo
2006-01-22 9:36 ` Jeff Garzik
2006-01-22 7:58 ` [PATCH 08/12] libata: fix handling of race between timeout and completion Tejun Heo
2006-01-22 9:41 ` Jeff Garzik
2006-01-22 7:58 ` [PATCH 11/12] libata: ignore normal qc completion during EH Tejun Heo
2006-01-22 9:53 ` Jeff Garzik
2006-01-22 11:09 ` Tejun Heo
2006-01-22 7:58 ` [PATCH 07/12] libata: implement and apply ata_eh_qc_complete/retry() Tejun Heo
2006-01-22 7:58 ` [PATCH 10/12] libata: implement ATA_FLAG_IN_EH port flag Tejun Heo
2006-01-22 9:49 ` Jeff Garzik
2006-01-22 7:58 ` [PATCH 12/12] libata: EH / pio tasks synchronization Tejun Heo
2006-01-22 9:58 ` Jeff Garzik
2006-01-22 10:27 ` Tejun Heo
2006-01-22 7:58 ` [PATCH 09/12] libata: kill NULL qc handling from ->eng_timeout callbacks Tejun Heo
2006-01-22 9:10 ` [PATCHSET] libata: various fixes related to EH Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43D350B2.3020009@pobox.com \
--to=jgarzik@pobox.com \
--cc=albertcc@tw.ibm.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.