Re: [PATCH 3/4] aic79xx: SLOWCRC fix

[Hannes Reinecke <hare@suse.de>]

Arjan van de Ven wrote:
> On Tue, 2006-01-24 at 10:44 +0100, Hannes Reinecke wrote:
>>  	/*
>> +	 * Slow down our CRC interval to be
>> +	 * compatible with packetized U320 devices
>> +	 * that can't handle a CRC at full speed
>> +	 */
>> +	if (ahd->features & AHD_AIC79XXB_SLOWCRC) {
>> +		con_opts |= ENSLOWCRC;
>> +	}
> 
> since this seems to be a device quirk, shouldn't this just be part of
> the scsi blacklist and have a quirk there? Maybe with a generic option
> to trigger that quirk as well rather than a per driver module one...
> 
Errm.

blacklisting is for device only, not for HBAs, or?
This slowcrc is a fix for buggy adaptec hardware. Nothing to do with the
devices connected to it...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html