From: Patrick McHardy <kaber@trash.net>
To: Holger Eitzenberger <heitzenberger@astaro.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] [NETFILTER] Fix CID offset bug in PPTP NAT helper
Date: Tue, 24 Jan 2006 18:59:44 +0100 [thread overview]
Message-ID: <43D66B10.6040803@trash.net> (raw)
In-Reply-To: <11381105772146-git-send-email-heitzenberger@astaro.com>
Holger Eitzenberger wrote:
> The recent (kernel 2.6.15.1) fix for PPTP NAT helper introduced a
> bug - which only appears if DEBUGP is enabled though.
>
> The calculation of the CID offset into a PPTP request struct is
> not correct, so that at least not the correct CID is displayed
> if DEBUGP is enabled.
>
> This patch corrects CID offset calculation and introduces a #define
> for that.
That was my bad. Patch applied, thanks.
next prev parent reply other threads:[~2006-01-24 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-24 13:49 PPTP NAT helper fix Holger Eitzenberger
2006-01-24 13:49 ` [PATCH] [NETFILTER] Fix CID offset bug in PPTP NAT helper Holger Eitzenberger
2006-01-24 17:59 ` Patrick McHardy [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-24 19:36 Greg Scott
2006-01-25 8:47 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43D66B10.6040803@trash.net \
--to=kaber@trash.net \
--cc=heitzenberger@astaro.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.