Re: policycoreutils 1.29.10

[Daniel J Walsh <dwalsh@redhat.com>]

Stephen Smalley wrote:
> On Wed, 2006-01-25 at 11:16 -0500, Daniel J Walsh wrote:
>   
>> Here is my latest diff also, mainly  adding translation support to 
>> semanage and cleaning up some of the error reporting.
>>     
>
>   
>> diff --exclude-from=exclude -N -u -r nsapolicycoreutils/semanage/semanage policycoreutils-1.29.10/semanage/semanage
>> --- nsapolicycoreutils/semanage/semanage	2006-01-20 10:37:37.000000000 -0500
>> +++ policycoreutils-1.29.10/semanage/semanage	2006-01-20 15:17:56.000000000 -0500
>> -	-v, --verbose    verbose output\n\
>>     
Yes get rid of all -v and verbose stuff.
>> +	def get_options():
>> +		valid_option={}
>> +		valid_everyone=[ '-a', '--add', '-d', '--delete', '-m', '--modify', '-l', '--list', '-h', '--help', '-n', '--noheading' ]
>> +		valid_option["login"] = []
>> +		valid_option["login"] += valid_everyone + [ '-s', '--seuser', '-r', '--range']
>> +		valid_option["user"] = []
>> +		valid_option["user"] += valid_everyone + [ '-L', '--level', '-r', '--range', '-R', '--roles' ] 
>> +		valid_option["port"] = []
>> +		valid_option["port"] += valid_everyone + [ '-t', '--type', '-r', '--range'] 
>> +		valid_option["port"] = []
>> +		valid_option["port"] += valid_everyone + [ '-t', '--type', '-r', '--range', '-p', '--protocol' ] 
>>     
>
> Cut-and-paste error - multiple definitions for "port"
>
>   
>> +		valid_option["interface"] = []
>> +		valid_option["interface"] += valid_everyone + [ '-t', '--type', '-r', '--range'] 
>> +		valid_option["fcontext"] = []
>> +		valid_option["fcontext"] += valid_everyone + [ '-f', '--ftype', '-s', '--seuser',  '-t', '--type', '-r', '--range'] 
>> +		valid_option["translation"] = []
>> +		valid_option["fcontext"] += valid_everyone + [ '-T', '--trans' ]
>>     
>
> Cut-and-paste error - last one should be for "translation", right?
>
>   
>>  		gopts, cmds = getopt.getopt(args,
>> -					    'adf:lhmnp:P:s:R:L:r:t:vT:',
>> +					    'adf:lhmnp:s:R:L:r:t:vT:',
>>     
>
> -v still listed here.
>
>
>   
>>  			if o == "-R" or o == '--roles':
>> -				roles = roles + " " + a
>> +				roles = a
>>     
>
> Why?  Aggregating multiple role specs seemed nice.  Implementation
> problem?
>   
How do I do a modify?

As a user I might be confused by the semantic
Does
-m -R user_r
add user_r or
replace all existing roles with user_r?

>   
>> +.I                \-R, \-\-role
>> +SELinux Roles.  You must inclose multiple roles within quotes, separate by spaces.
>> +.TP
>>     
>
> Reverts Russell's change, which as he said seems more script-friendly
> and user-friendly (aggregate multiple -R options together).
>
>   
I can be shouted down on this one.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.