From: jim.cromie@gmail.com (Jim Cromie)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [patch 2/2] hwmon/pc87360: combine sysfs callbacks
Date: Thu, 26 Jan 2006 19:57:31 +0000 [thread overview]
Message-ID: <43D929AB.9060508@gmail.com> (raw)
From: Jim Cromie <jim.cromie at gmail.com>
2. hwmon-pc87360-sysfs-combo-callbacks.patch
This combines individual (show|set)_Sensor_Attr callbacks into
(show|set)_Sensor callbacks that handle all that Sensor's Attrs,
based upon value in sensor_device_attribute_2.nr
Signed-off-by: Jim Cromie <jim.cromie at gmail.com>
---
diffstat hwmon-pc87360-sysfs-combo-callbacks.patch
pc87360.c | 545
+++++++++++++++++++++++++++-----------------------------------
1 files changed, 246 insertions(+), 299 deletions(-)
patch yields a non-trivial size reduction (b4, after)
14588 3224 16 17828 45a4 A-2/drivers/hwmon/pc87360.ko
13124 3224 16 16364 3fec A-3/drivers/hwmon/pc87360.ko
ie about 10%
Combining all show_X (for all X) together is possible, but would
compromise clarity,
(ie the separation of the sensor code) and would save only ~ 1/5 th
additional space.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hwmon-pc87360-sysfs-combo-callbacks.patch
Type: text/x-patch
Size: 31627 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060126/ff45db23/hwmon-pc87360-sysfs-combo-callbacks-0001.bin
reply other threads:[~2006-01-26 19:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43D929AB.9060508@gmail.com \
--to=jim.cromie@gmail.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.