From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <43DDCB6D.8060405@domain.hid> Date: Mon, 30 Jan 2006 09:16:45 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Xenomai-core] Missing IRQ end function on PowerPC References: <43CE1C28.6060001@domain.hid> <17359.34362.870823.168739@domain.hid> <43CF8ECF.4020805@domain.hid> <17359.37814.257893.95482@domain.hid> <43DD481B.4010603@domain.hid> In-Reply-To: <43DD481B.4010603@domain.hid> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig3FAB110EFE27B327EDE805B0" Sender: jan.kiszka@domain.hid List-Id: "Xenomai life and development \(bug reports, patches, discussions\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe Gerum Cc: xenomai@xenomai.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3FAB110EFE27B327EDE805B0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Philippe Gerum wrote: > Gilles Chanteperdrix wrote: >> Wolfgang Grandegger wrote: >> > Therefore we need a dedicated function to re-enable interrupts in >> the > ISR. We could name it *_end_irq, but maybe *_enable_isr_irq is >> more > obvious. On non-PPC archs it would translate to *_irq_enable. >> I > realized, that *_irq_enable is used in various place/skins and >> therefore > I have not yet provided a patch. >> >> The function xnarch_irq_enable seems to be called in only two function= s, >> xintr_enable and xnintr_irq_handler when the flag XN_ISR_ENABLE is set= =2E >> >> In any case, since I am not sure if this has to be done at the Adeos >> level or in Xenomai, we will wait for Philippe to come back and decide= =2E >> >=20 > ->enable() and ->end() all mixed up illustrates a silly x86 bias I once= > had. We do need to differentiate the mere enabling from the IRQ epilogu= e > at PIC level since Linux does it - i.e. we don't want to change the > semantics here. >=20 > I would go for adding xnarch_end_irq -> rthal_irq_end to stick with the= > Linux naming scheme, and have the proper epilogue done from there on a > per-arch basis. >=20 > Current uses of xnarch_enable_irq() should be reserved to the > non-epilogue case, like xnintr_enable() i.e. forcibly unmasking the IRQ= > source at PIC level outside of any ISR context for such interrupt (*). > XN_ISR_ENABLE would trigger a call to xnarch_end_irq, instead of > xnarch_enable_irq. I see no reason for this fix to leak to the Adeos > layer, since the HAL already controls the way interrupts are ended > actually; it just does it improperly on some platforms. >=20 > (*) Jan, does rtdm_irq_enable() have the same meaning, or is it intende= d > to be used from the ISR too in order to revalidate the source at PIC le= vel? >=20 Nope, rtdm_irq_enable() was never intended to re-enable an IRQ line after an interrupt, and the documentation does not suggest this either. I see no problem here. Jan --------------enig3FAB110EFE27B327EDE805B0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFD3ctxniDOoMHTA+kRAnyuAJ9eT/gH0qCQjLNjJw+zvSahS7aZ+wCghQQI GMMbPzkEPXP+9e1KPNuWOLM= =7xfb -----END PGP SIGNATURE----- --------------enig3FAB110EFE27B327EDE805B0--