From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <43DE3757.2070006@domain.hid>
Date: Mon, 30 Jan 2006 16:57:11 +0100
From: Philippe Gerum <rpm@xenomai.org>
MIME-Version: 1.0
Subject: Re: [Xenomai-core] [BUG?] dead code in ipipe_grab_irq
References: <43DE29B3.5000005@domain.hid> <43DE32BF.30207@domain.hid>
In-Reply-To: <43DE32BF.30207@domain.hid>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: "Xenomai life and development \(bug reports, patches,
	discussions\)" <xenomai.xenomai.org>
List-Unsubscribe: <https://mail.gna.org/listinfo/xenomai-core>,
	<mailto:xenomai-core-request@domain.hid>
List-Archive: </public/xenomai-core>
List-Post: <mailto:xenomai@xenomai.org>
List-Help: <mailto:xenomai-core-request@domain.hid>
List-Subscribe: <https://mail.gna.org/listinfo/xenomai-core>,
	<mailto:xenomai-core-request@domain.hid>
To: Heikki Lindholm <holindho@domain.hid>
Cc: xenomai@xenomai.org

Heikki Lindholm wrote:
> Anders Blomdell kirjoitti:
> 
>> In the following code (ppc), shouldn't first be either declared static 
>> or deleted? To me it looks like first is always equal to one when the 
>> else clause is evaluated.
> 
> 
> You're right. "first" doesn't need to be there at all, it's probably an 
> old copy of something in the kernel.
> 

Yep; used to be a while() loop in the original implementation we do not perform here.

>> asmlinkage int __ipipe_grab_irq(struct pt_regs *regs)
>> {
>>         extern int ppc_spurious_interrupts;
>>         ipipe_declare_cpuid;
>>         int irq, first = 1;
>>
>>         if ((irq = ppc_md.get_irq(regs)) >= 0) {
>>                 __ipipe_handle_irq(irq, regs);
>>                 first = 0;
>>         } else if (irq != -2 && first)
>>                 ppc_spurious_interrupts++;
>>
>>         ipipe_load_cpuid();
>>
>>         return (ipipe_percpu_domain[cpuid] == ipipe_root_domain &&
>>                 !test_bit(IPIPE_STALL_FLAG,
>>                           &ipipe_root_domain->cpudata[cpuid].status));
>> }
>>
>>
>> Regards
>>
>> Anders Blomdell
>>
>>
>>
>> _______________________________________________
>> Xenomai-core mailing list
>> Xenomai-core@domain.hid
>> https://mail.gna.org/listinfo/xenomai-core
> 
> 
> 
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core
> 


-- 

Philippe.