All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Lidel <Markus.Lidel@shadowconnect.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: PCI layer: Need for enable/disable counting (was  disable PCI device if it is enabled	before probing)
Date: Tue, 31 Jan 2006 10:31:49 +0100	[thread overview]
Message-ID: <43DF2E85.4000200@shadowconnect.com> (raw)
In-Reply-To: <1138662069.31089.89.camel@localhost.localdomain>

Hello,

Alan Cox wrote:
> On Llu, 2006-01-30 at 20:33 +0100, Markus Lidel wrote:
>> I've searched for a function enabled() or so, but didn't find anything. 
>> Could you tell me the right way to do it normally?
> Right now there isn't one. I've hit this problem with the new libata

OK, at least i haven't overseen something :-D

> layer stuff having successfully disabled my root pci bridge on unload at
> least once.

Hmmm, think this is something everyone could use...

> Would be easy to add one but I suspect it should be rcounted so that
> enable/disable just stack naturally ?

Sounds great to me... So the verification if the device is enabled before 
could be completely removed from my and probably others code...

> What do people want from such an interface and should it also start boot
> enabled devices at a count of 1 or just the bridges/video class
> devices ?

Hmmm, i don't know what happens if a boot enabled device is disabled, but 
from my point of view i would start at 1 :-D

Probably also the probing function could also enable the device, so the 
subsystems don't have to do it on there own? But because i don't know PCI 
stuff very well i don't know if this makes sense at all...

Thank you very much!


Best regards,


Markus Lidel
------------------------------------------
Markus Lidel (Senior IT Consultant)

Shadow Connect GmbH
Carl-Reisch-Weg 12
D-86381 Krumbach
Germany

Phone:  +49 82 82/99 51-0
Fax:    +49 82 82/99 51-11

E-Mail: Markus.Lidel@shadowconnect.com
URL:    http://www.shadowconnect.com

      reply	other threads:[~2006-01-31  9:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-23 23:29 [PATCH 1/2] I2O: don't disable PCI device if it is enabled before probing Markus Lidel
2006-01-30 18:17 ` Alan Cox
2006-01-30 19:33   ` Markus Lidel
2006-01-30 23:01     ` PCI layer: Need for enable/disable counting (was disable PCI device if it is enabled before probing) Alan Cox
2006-01-31  9:31       ` Markus Lidel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43DF2E85.4000200@shadowconnect.com \
    --to=markus.lidel@shadowconnect.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.