From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Anderson Briglia <anderson.briglia@indt.org.br>
Cc: linux-kernel@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [patch 3/5] MMC OMAP driver
Date: Tue, 31 Jan 2006 16:02:55 +0100 [thread overview]
Message-ID: <43DF7C1F.8020304@drzeus.cx> (raw)
In-Reply-To: <43DF6807.9020907@indt.org.br>
Anderson Briglia wrote:
> Here are some misc fixes we've had in the OMAP tree. Might be worth
> testing them on other platforms too.
>
> Index: linux-2.6.15-mmc_omap/drivers/mmc/mmc.c
> ===================================================================
> --- linux-2.6.15-mmc_omap.orig/drivers/mmc/mmc.c 2006-01-30 10:24:50.000000000 -0400
> +++ linux-2.6.15-mmc_omap/drivers/mmc/mmc.c 2006-01-30 10:25:19.000000000 -0400
> @@ -704,6 +704,7 @@ static void mmc_power_up(struct mmc_host
> int bit = fls(host->ocr_avail) - 1;
>
> host->ios.vdd = bit;
> + host->ios.clock = host->f_min;
> host->ios.bus_mode = MMC_BUSMODE_OPENDRAIN;
> host->ios.chip_select = MMC_CS_DONTCARE;
> host->ios.power_mode = MMC_POWER_UP;
> @@ -712,7 +713,6 @@ static void mmc_power_up(struct mmc_host
>
> mmc_delay(1);
>
> - host->ios.clock = host->f_min;
> host->ios.power_mode = MMC_POWER_ON;
> host->ops->set_ios(host, &host->ios);
>
Why? What you're doing there is enable the clock at the same time as the
power, instead of just the power first. To me, that seems less safe.
> @@ -747,6 +747,7 @@ static int mmc_send_op_cond(struct mmc_h
> if (cmd.resp[0] & MMC_CARD_BUSY || ocr == 0)
> break;
>
> + mmc_delay(1);
> err = MMC_ERR_TIMEOUT;
>
> mmc_delay(10);
This seems particularly useless. Probably just a remnant from a separate
mmc_delay() addition to the one that's in mainline now.
Rgds
Pierre
next prev parent reply other threads:[~2006-01-31 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 13:37 [patch 3/5] MMC OMAP driver Anderson Briglia
2006-01-31 15:02 ` Pierre Ossman [this message]
2006-02-01 10:21 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43DF7C1F.8020304@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=anderson.briglia@indt.org.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.