From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Jean-Fran?ois Stenuit <jfs@keytradebank.com>,
Keith Mannthey <kmannth@gmail.com>, "0602@eq.cz" <0602@eq.cz>,
Linux-ide <linux-ide@vger.kernel.org>
Subject: Re: [PATCH] ata_piix: ignore all zero PCS value on ICH5's
Date: Wed, 01 Feb 2006 11:01:53 +0900 [thread overview]
Message-ID: <43E01691.9040600@gmail.com> (raw)
In-Reply-To: <43DC510A.1090101@pobox.com>
Jeff Garzik wrote:
> Tejun Heo wrote:
>
>> Some ICH5's report 0 for PCS even when they have active working ports.
>> This patch makes piix_sata_probe() ignore 0 PCS value on ICH5's and
>> probe all ports in such cases. And while at it, remove bogus
>> assignment to mask.
>>
>
> I'm just not too thrilled about this. I wonder if its an isolated
> incident related to power or something. I would wait for more problem
> reports, before applying this.
>
I'm not too sure about this one either, but we have two independent
consistent bug reports and PCS handling in ata_piix isn't that necessary
or strict to begin with, so....
How about making it a driver option? ata_piix.ignore_PCS maybe?
--
tejun
next prev parent reply other threads:[~2006-02-01 2:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-28 20:52 totally random "VFS: Cannot open root device" 0602
2005-11-29 19:22 ` Keith Mannthey
2005-11-30 4:35 ` Tejun Heo
2005-11-30 9:05 ` Jean-François Stenuit
2005-11-30 16:30 ` Randy.Dunlap
2005-12-01 9:42 ` Jean-François Stenuit
2005-12-01 11:20 ` Jean-François Stenuit
2005-11-30 13:07 ` 0602
2005-11-30 22:05 ` Keith Mannthey
2005-12-01 9:40 ` Jean-François Stenuit
2005-12-01 11:20 ` Tejun Heo
2005-12-01 12:59 ` Jean-François Stenuit
2005-12-01 13:29 ` Tejun Heo
2005-12-01 15:34 ` 0602
2005-12-02 1:53 ` Jeff Garzik
2005-12-02 3:00 ` Tejun Heo
2005-12-02 3:26 ` [PATCH] ata_piix: ignore all zero PCS value on ICH5's Tejun Heo
2005-12-02 12:40 ` 0602
2005-12-05 10:07 ` Jean-François Stenuit
2005-12-05 10:17 ` Tejun Heo
2006-01-29 5:22 ` Jeff Garzik
2006-02-01 2:01 ` Tejun Heo [this message]
2006-02-09 9:23 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43E01691.9040600@gmail.com \
--to=htejun@gmail.com \
--cc=0602@eq.cz \
--cc=jfs@keytradebank.com \
--cc=jgarzik@pobox.com \
--cc=kmannth@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.