From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tokarev Date: Wed, 01 Feb 2006 09:26:10 +0000 Subject: Re: [patch 14/44] generic hweight{64,32,16,8}() Message-Id: <43E07EB2.4020409@tls.msk.ru> List-Id: References: <20060201090224.536581000@localhost.localdomain> <20060201090325.905071000@localhost.localdomain> <200602011006.09596.ak@suse.de> In-Reply-To: <200602011006.09596.ak@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andi Kleen Cc: Akinobu Mita , linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Russell King , Ian Molton , dev-etrax@axis.com, David Howells , Yoshinori Sato , Linus Torvalds , linux-ia64@vger.kernel.org, Hirokazu Takata , linux-m68k@vger.kernel.org, Greg Ungerer , linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, linuxppc-dev@ozlabs.org, linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Chris Zankel Andi Kleen wrote: > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > >>+static inline unsigned int hweight32(unsigned int w) [] > How large are these functions on x86? Maybe it would be better to not inline them, > but put it into some C file out of line. hweight8 47 bytes hweight16 76 bytes hweight32 97 bytes hweight64 56 bytes (NOT inlining hweight32) hweight64 197 bytes (inlining hweight32) Those are when compiled as separate non-inlined functions, with pushl %ebp and ret. /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 01 Feb 2006 09:21:33 +0000 (GMT) Received: from hobbit.corpit.ru ([81.13.94.6]:45920 "EHLO hobbit.corpit.ru") by ftp.linux-mips.org with ESMTP id S8133742AbWBAJVM (ORCPT ); Wed, 1 Feb 2006 09:21:12 +0000 Received: from localhost (localhost [127.0.0.1]) by hobbit.corpit.ru (Postfix) with ESMTP id 39BB82A7F1; Wed, 1 Feb 2006 12:26:07 +0300 (MSK) (envelope-from mjt@tls.msk.ru) Received: from [192.168.1.1] (paltus.tls.msk.ru [192.168.1.1]) by hobbit.corpit.ru (Postfix) with ESMTP; Wed, 1 Feb 2006 12:26:07 +0300 (MSK) (envelope-from mjt@tls.msk.ru) Message-ID: <43E07EB2.4020409@tls.msk.ru> Date: Wed, 01 Feb 2006 12:26:10 +0300 From: Michael Tokarev User-Agent: Debian Thunderbird 1.0.2 (X11/20051002) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andi Kleen CC: Akinobu Mita , linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Russell King , Ian Molton , dev-etrax@axis.com, David Howells , Yoshinori Sato , Linus Torvalds , linux-ia64@vger.kernel.org, Hirokazu Takata , linux-m68k@lists.linux-m68k.org, Greg Ungerer , linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, linuxppc-dev@ozlabs.org, linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Chris Zankel Subject: Re: [patch 14/44] generic hweight{64,32,16,8}() References: <20060201090224.536581000@localhost.localdomain> <20060201090325.905071000@localhost.localdomain> <200602011006.09596.ak@suse.de> In-Reply-To: <200602011006.09596.ak@suse.de> X-Enigmail-Version: 0.91.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 10279 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: mjt@tls.msk.ru Precedence: bulk X-list: linux-mips Andi Kleen wrote: > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > >>+static inline unsigned int hweight32(unsigned int w) [] > How large are these functions on x86? Maybe it would be better to not inline them, > but put it into some C file out of line. hweight8 47 bytes hweight16 76 bytes hweight32 97 bytes hweight64 56 bytes (NOT inlining hweight32) hweight64 197 bytes (inlining hweight32) Those are when compiled as separate non-inlined functions, with pushl %ebp and ret. /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hobbit.corpit.ru (hobbit.corpit.ru [81.13.94.6]) by ozlabs.org (Postfix) with ESMTP id 19B32689D9 for ; Wed, 1 Feb 2006 20:52:24 +1100 (EST) Message-ID: <43E07EB2.4020409@tls.msk.ru> Date: Wed, 01 Feb 2006 12:26:10 +0300 From: Michael Tokarev MIME-Version: 1.0 To: Andi Kleen Subject: Re: [patch 14/44] generic hweight{64,32,16,8}() References: <20060201090224.536581000@localhost.localdomain> <20060201090325.905071000@localhost.localdomain> <200602011006.09596.ak@suse.de> In-Reply-To: <200602011006.09596.ak@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, Ian Molton , David Howells , linuxppc-dev@ozlabs.org, Greg Ungerer , sparclinux@vger.kernel.org, Miles Bader , Yoshinori Sato , Hirokazu Takata , linuxsh-dev@lists.sourceforge.net, Linus Torvalds , Ivan Kokshaysky , Richard Henderson , Akinobu Mita , Chris Zankel , dev-etrax@axis.com, ultralinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linuxsh-shmedia-dev@lists.sourceforge.net, linux390@de.ibm.com, Russell King , parisc-linux@parisc-linux.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Andi Kleen wrote: > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > >>+static inline unsigned int hweight32(unsigned int w) [] > How large are these functions on x86? Maybe it would be better to not inline them, > but put it into some C file out of line. hweight8 47 bytes hweight16 76 bytes hweight32 97 bytes hweight64 56 bytes (NOT inlining hweight32) hweight64 197 bytes (inlining hweight32) Those are when compiled as separate non-inlined functions, with pushl %ebp and ret. /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tokarev Date: Wed, 01 Feb 2006 09:26:10 +0000 Subject: Re: [patch 14/44] generic hweight{64,32,16,8}() Message-Id: <43E07EB2.4020409@tls.msk.ru> List-Id: References: <20060201090224.536581000@localhost.localdomain> <20060201090325.905071000@localhost.localdomain> <200602011006.09596.ak@suse.de> In-Reply-To: <200602011006.09596.ak@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andi Kleen Cc: Akinobu Mita , linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Russell King , Ian Molton , dev-etrax@axis.com, David Howells , Yoshinori Sato , Linus Torvalds , linux-ia64@vger.kernel.org, Hirokazu Takata , linux-m68k@lists.linux-m68k.org, Greg Ungerer , linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, linuxppc-dev@ozlabs.org, linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Chris Zankel Andi Kleen wrote: > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > >>+static inline unsigned int hweight32(unsigned int w) [] > How large are these functions on x86? Maybe it would be better to not inline them, > but put it into some C file out of line. hweight8 47 bytes hweight16 76 bytes hweight32 97 bytes hweight64 56 bytes (NOT inlining hweight32) hweight64 197 bytes (inlining hweight32) Those are when compiled as separate non-inlined functions, with pushl %ebp and ret. /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030240AbWBAJ03 (ORCPT ); Wed, 1 Feb 2006 04:26:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932432AbWBAJ02 (ORCPT ); Wed, 1 Feb 2006 04:26:28 -0500 Received: from hobbit.corpit.ru ([81.13.94.6]:22103 "EHLO hobbit.corpit.ru") by vger.kernel.org with ESMTP id S932430AbWBAJ0Y (ORCPT ); Wed, 1 Feb 2006 04:26:24 -0500 Message-ID: <43E07EB2.4020409@tls.msk.ru> Date: Wed, 01 Feb 2006 12:26:10 +0300 From: Michael Tokarev User-Agent: Debian Thunderbird 1.0.2 (X11/20051002) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andi Kleen CC: Akinobu Mita , linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Russell King , Ian Molton , dev-etrax@axis.com, David Howells , Yoshinori Sato , Linus Torvalds , linux-ia64@vger.kernel.org, Hirokazu Takata , linux-m68k@vger.kernel.org, Greg Ungerer , linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, linuxppc-dev@ozlabs.org, linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Chris Zankel Subject: Re: [patch 14/44] generic hweight{64,32,16,8}() References: <20060201090224.536581000@localhost.localdomain> <20060201090325.905071000@localhost.localdomain> <200602011006.09596.ak@suse.de> In-Reply-To: <200602011006.09596.ak@suse.de> X-Enigmail-Version: 0.91.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andi Kleen wrote: > On Wednesday 01 February 2006 10:02, Akinobu Mita wrote: > >>+static inline unsigned int hweight32(unsigned int w) [] > How large are these functions on x86? Maybe it would be better to not inline them, > but put it into some C file out of line. hweight8 47 bytes hweight16 76 bytes hweight32 97 bytes hweight64 56 bytes (NOT inlining hweight32) hweight64 197 bytes (inlining hweight32) Those are when compiled as separate non-inlined functions, with pushl %ebp and ret. /mjt