From: Andy Whitcroft <apw@shadowen.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, Martin Bligh <mbligh@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xquad_portio fix declaration missmatch
Date: Thu, 02 Feb 2006 21:31:26 +0000 [thread overview]
Message-ID: <43E27A2E.9020000@shadowen.org> (raw)
In-Reply-To: <20060202172609.GA4231@mipter.zuzino.mipt.ru>
Alexey Dobriyan wrote:
> On Thu, Feb 02, 2006 at 12:43:06AM +0000, Andy Whitcroft wrote:
>
>>xquad_portio fix declaration missmatch
>
>
>> arch/i386/boot/compressed/misc.c:125: error: static declaration of
>> 'xquad_portio' follows non-static declaration
>> include/asm/io.h:315: error: previous declaration of 'xquad_portio' was here
>
>
>>--- reference/arch/i386/boot/compressed/misc.c
>>+++ current/arch/i386/boot/compressed/misc.c
>>@@ -122,7 +122,7 @@ static int vidport;
>> static int lines, cols;
>>
>> #ifdef CONFIG_X86_NUMAQ
>>-static void * xquad_portio = NULL;
>>+void * xquad_portio = NULL;
>> #endif
>
>
> Can you explain why it should stay in misc.c?
Indeed it does feel like it should be a numaq special in the numaq
specific files. I'll spin that and test it and see if there is a reason
why its _not_ like that already.
-apw
next prev parent reply other threads:[~2006-02-02 21:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-02 0:43 [PATCH] xquad_portio fix declaration missmatch Andy Whitcroft
2006-02-02 17:26 ` Alexey Dobriyan
2006-02-02 21:31 ` Andy Whitcroft [this message]
2006-02-02 21:59 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43E27A2E.9020000@shadowen.org \
--to=apw@shadowen.org \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.