All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] SCSI Userspace Target: scsi-ml changes
Date: Mon, 06 Feb 2006 11:54:48 -0600	[thread overview]
Message-ID: <43E78D68.7010301@cs.wisc.edu> (raw)
In-Reply-To: <20060206113356T.fujita.tomonori@lab.ntt.co.jp>

FUJITA Tomonori wrote:
> From: James Bottomley <James.Bottomley@SteelEye.com>
> Subject: Re: [PATCH RFC 1/3] SCSI Userspace Target: scsi-ml changes
> Date: Sun, 05 Feb 2006 12:30:28 -0600
> 
> 
>>OK ... I think this looks good enough to fix up in tree.  I just have
>>one minor quibble, so could you fix that and I'll put it in.
>>
>>On Tue, 2006-01-24 at 20:58 -0600, Mike Christie wrote:
>>
>>>@@ -31,6 +32,7 @@ struct scsi_pointer {
>>> struct scsi_cmnd {
>>>        int     sc_magic;
>>> 
>>>+       struct Scsi_Host *shost;
>>>        struct scsi_device *device;
>>
>>This is an unnecessary addition; you can get this from device->host.
> 
> 
> Thanks a lot. I've just fixed this.
> 

We actually need ths shost pointer becuase we do not represent the LU in 
the kernel. So we go from:

scsi_host -> host's uspace request_queue (used to pass commands and 
messages from the target LLD interrup handler to our netlink 
code/userspace -> in userspace we represent the target, device/LU, and host.

Tomo did you add a virtual scsi_device somewhere?

  reply	other threads:[~2006-02-06 17:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-25  2:58 [PATCH RFC 1/3] SCSI Userspace Target: scsi-ml changes Mike Christie
2006-02-05 18:30 ` James Bottomley
2006-02-06  2:33   ` FUJITA Tomonori
2006-02-06 17:54     ` Mike Christie [this message]
2006-02-06 18:02       ` James Bottomley
2006-02-06 18:22         ` Mike Christie
2006-02-06 18:30           ` Mike Christie
2006-02-06 18:33           ` James Bottomley
2006-02-06 18:45             ` Mike Christie
2006-02-06 22:14               ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43E78D68.7010301@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=James.Bottomley@SteelEye.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.