All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] .gitignore git-rerere and config.mak
@ 2006-02-07 17:23 Andreas Ericsson
  2006-02-07 18:20 ` Junio C Hamano
  0 siblings, 1 reply; 7+ messages in thread
From: Andreas Ericsson @ 2006-02-07 17:23 UTC (permalink / raw)
  To: git

Signed-off-by: Andreas Ericsson <ae@op5.se>

---

 .gitignore |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

0a04811b6d4a6673869cd078471cd1ee6db31e5a
diff --git a/.gitignore b/.gitignore
index 513f22e..d7e8d2a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -78,6 +78,7 @@ git-relink
 git-repack
 git-repo-config
 git-request-pull
+git-rerere
 git-reset
 git-resolve
 git-rev-list
@@ -123,3 +124,4 @@ git-core.spec
 libgit.a
 *.o
 *.py[co]
+config.mak
-- 
1.1.6.g53f3

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] .gitignore git-rerere and config.mak
  2006-02-07 17:23 [PATCH] .gitignore git-rerere and config.mak Andreas Ericsson
@ 2006-02-07 18:20 ` Junio C Hamano
  2006-02-07 18:52   ` Johannes Schindelin
  2006-02-08  3:55   ` Jason Riedy
  0 siblings, 2 replies; 7+ messages in thread
From: Junio C Hamano @ 2006-02-07 18:20 UTC (permalink / raw)
  To: Andreas Ericsson; +Cc: git

Andreas Ericsson <ae@op5.se> writes:

> --- a/.gitignore
> +++ b/.gitignore
> @@ -123,3 +124,4 @@ git-core.spec
>  libgit.a
>  *.o
>  *.py[co]
> +config.mak

I am not sure about this part.  It is plausible that somebody
who privately uses config.mak has it in _his_ repository under
version control.  Should we list it in .gitignore?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] .gitignore git-rerere and config.mak
  2006-02-07 18:20 ` Junio C Hamano
@ 2006-02-07 18:52   ` Johannes Schindelin
  2006-02-07 23:23     ` Radoslaw Szkodzinski
  2006-02-08  3:55   ` Jason Riedy
  1 sibling, 1 reply; 7+ messages in thread
From: Johannes Schindelin @ 2006-02-07 18:52 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Andreas Ericsson, git

Hi,

On Tue, 7 Feb 2006, Junio C Hamano wrote:

> Andreas Ericsson <ae@op5.se> writes:
> 
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -123,3 +124,4 @@ git-core.spec
> >  libgit.a
> >  *.o
> >  *.py[co]
> > +config.mak
> 
> I am not sure about this part.  It is plausible that somebody
> who privately uses config.mak has it in _his_ repository under
> version control.  Should we list it in .gitignore?

I have it in .gitignore. If there were changes to config.mak which I had 
in all my copies of git, I'd have them directly in the Makefile.

Hth,
Dscho

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] .gitignore git-rerere and config.mak
  2006-02-07 18:52   ` Johannes Schindelin
@ 2006-02-07 23:23     ` Radoslaw Szkodzinski
  2006-02-08  1:01       ` Junio C Hamano
  0 siblings, 1 reply; 7+ messages in thread
From: Radoslaw Szkodzinski @ 2006-02-07 23:23 UTC (permalink / raw)
  To: Johannes Schindelin; +Cc: Junio C Hamano, Andreas Ericsson, git

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]

Johannes Schindelin wrote:
> Hi,
> 
> On Tue, 7 Feb 2006, Junio C Hamano wrote:
> 
>> Andreas Ericsson <ae@op5.se> writes:
>>
>>> --- a/.gitignore
>>> +++ b/.gitignore
>>> @@ -123,3 +124,4 @@ git-core.spec
>>>  libgit.a
>>>  *.o
>>>  *.py[co]
>>> +config.mak
>> I am not sure about this part.  It is plausible that somebody
>> who privately uses config.mak has it in _his_ repository under
>> version control.  Should we list it in .gitignore?
> 
> I have it in .gitignore. If there were changes to config.mak which I had 
> in all my copies of git, I'd have them directly in the Makefile.
> 
> Hth,
> Dscho

Somehow git-rerere didn't end up getting included in .gitignore...

-- 
GPG Key id:  0xD1F10BA2
Fingerprint: 96E2 304A B9C4 949A 10A0  9105 9543 0453 D1F1 0BA2

AstralStorm


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] .gitignore git-rerere and config.mak
  2006-02-07 23:23     ` Radoslaw Szkodzinski
@ 2006-02-08  1:01       ` Junio C Hamano
  0 siblings, 0 replies; 7+ messages in thread
From: Junio C Hamano @ 2006-02-08  1:01 UTC (permalink / raw)
  To: Radoslaw Szkodzinski; +Cc: git

Radoslaw Szkodzinski <astralstorm@gorzow.mm.pl> writes:

> Somehow git-rerere didn't end up getting included in .gitignore...

Sorry for a bit confusing style of quoting.  I edited that part out,
which I did not disagree with, when I commented on the patch.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] .gitignore git-rerere and config.mak
  2006-02-07 18:20 ` Junio C Hamano
  2006-02-07 18:52   ` Johannes Schindelin
@ 2006-02-08  3:55   ` Jason Riedy
  2006-02-08  5:34     ` Junio C Hamano
  1 sibling, 1 reply; 7+ messages in thread
From: Jason Riedy @ 2006-02-08  3:55 UTC (permalink / raw)
  To: git

And Junio C Hamano writes:
 - I am not sure about this part.  It is plausible that somebody
 - who privately uses config.mak has it in _his_ repository under
 - version control.

Like me.  That way I don't have to worry about conflicts in the
Makefile.  But I can change .gitignore in those branches...

Jason

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] .gitignore git-rerere and config.mak
  2006-02-08  3:55   ` Jason Riedy
@ 2006-02-08  5:34     ` Junio C Hamano
  0 siblings, 0 replies; 7+ messages in thread
From: Junio C Hamano @ 2006-02-08  5:34 UTC (permalink / raw)
  To: Jason Riedy; +Cc: git

Jason Riedy <ejr@EECS.Berkeley.EDU> writes:

> And Junio C Hamano writes:
>  - I am not sure about this part.  It is plausible that somebody
>  - who privately uses config.mak has it in _his_ repository under
>  - version control.
>
> Like me.  That way I don't have to worry about conflicts in the
> Makefile.  But I can change .gitignore in those branches...

Or you can leave that as is.  .gitignore is used to sift
untracked files into two categories - ignored and unknown.  So
my initial worry was unfounded.

Sorry for the noise.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2006-02-08  5:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-07 17:23 [PATCH] .gitignore git-rerere and config.mak Andreas Ericsson
2006-02-07 18:20 ` Junio C Hamano
2006-02-07 18:52   ` Johannes Schindelin
2006-02-07 23:23     ` Radoslaw Szkodzinski
2006-02-08  1:01       ` Junio C Hamano
2006-02-08  3:55   ` Jason Riedy
2006-02-08  5:34     ` Junio C Hamano

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.