All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Albert Lee <albertcc@tw.ibm.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	Doug Maxey <dwm@maxeymade.com>
Subject: Re: irq-pio branch updated with Tejun's patches
Date: Wed, 08 Feb 2006 17:46:39 +0900	[thread overview]
Message-ID: <43E9AFEF.4010909@gmail.com> (raw)
In-Reply-To: <43E9AAE0.8020302@tw.ibm.com>

Albert Lee wrote:
> Jeff Garzik wrote:
> 
>>I updated the libata irq-pio branch with Tejun's patches.  I would
>>appreciate it if you could check my work, and make sure that everything
>>continues to function properly.
>>
> 
> 
> Sorry for the late reply.
> Still checking Tejun's patches, especially the EH vs polling PIO racing fix.
> 
> Fixed minor compiliation problem in the irq-pio branch with Tejun and your patches.
> Will submit those minor patches first.
> 

Hello, Albert.

This is sort of OT, but would it be possible to separate PIO 
issuing/interrupt handling from ata_qc_issue_prot and ata_host_intr?

As PIO implementation currently stands, a lldd must use those standard 
methods to use PIO, but some controllers need PIO handling but the stock 
issue and interrupt routines don't really fit. e.g. not-yet-working 
sata_inic162x.  Something like ata_qc_issue_pio and ata_qc_pio_intr maybe?

-- 
tejun

  parent reply	other threads:[~2006-02-08  8:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-27 14:23 irq-pio branch updated with Tejun's patches Jeff Garzik
2006-02-08  8:25 ` Albert Lee
2006-02-08  8:34   ` [PATCH 0/4] libata-dev: minor fix for irq-pio with Tejun's EH patches Albert Lee
2006-02-08  8:37     ` [PATCH 1/4] libata-dev: Fix array index value in ata_rwcmd_protocol() Albert Lee
2006-02-09  9:26       ` Jeff Garzik
2006-02-08  8:48     ` [PATCH 2/4] libata-dev: Use new ata_queue_pio_task() for PIO polling task Albert Lee
2006-02-08  8:50     ` [PATCH 3/4] libata-dev: Use new AC_ERR_* flags Albert Lee
2006-02-08  8:51     ` [PATCH 4/4] libata-dev: Minor comment fix Albert Lee
2006-02-08  8:46   ` Tejun Heo [this message]
2006-02-09  3:23     ` irq-pio branch updated with Tejun's patches Albert Lee
2006-02-09  3:58       ` Tejun Heo
2006-02-09  9:21         ` Jeff Garzik
2006-02-09  9:31           ` Tejun
2006-02-09  9:17       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43E9AFEF.4010909@gmail.com \
    --to=htejun@gmail.com \
    --cc=albertcc@tw.ibm.com \
    --cc=dwm@maxeymade.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.