Re: [PATCH] Convert drivers to new irq trigger modes

[Dirk Behme <dirk.behme@googlemail.com>]

Hello Juha,

Juha Yrjölä wrote:
> Hi Dirk,
> 
> On Tue, Feb 07, 2006 at 06:32:58PM +0100, ext Dirk Behme wrote:
> 
>>  	int			irq;
>> +	int			irq_type;
> 
> This doesn't seem to be used anywhere.

To which file do you refer here? isp1301_omap.c, tps65010.c 
or omap_ts.h? I use irq_type in all of them.

I thought I use irq_type in all three files: isp->irq_type, 
  tps->irq_type and ts->irq_type?

>> +	isp->irq_type = SA_SAMPLE_RANDOM;
>>  	isp->client.addr = address;
>>  	i2c_set_clientdata(&isp->client, isp);
>>  	isp->client.adapter = bus;
>> @@ -1602,7 +1604,7 @@ fail1:
>>  		isp->irq = OMAP_GPIO_IRQ(2);
>>  		omap_request_gpio(2);
>>  		omap_set_gpio_direction(2, 1);
>> -		set_irq_type(isp->irq, IRQT_FALLING);
>> +		isp->irq_type = SA_TRIGGER_FALLING;
> 
> You should be ORring here.  Otherwise you lose the SA_SAMPLE_RANDOM flag.

It is intended to lose SA_SAMPLE_RANDOM here. 
SA_SAMPLE_RANDOM is the default and shall be used by 
request_irq() on boards which don't need special trigger 
setting. But on boards which need special trigger level 
setting this shall be overridden by the correct setting.

Best regards

Dirk