diff for duplicates of <43EA7808.6060105@hp.com> diff --git a/a/1.txt b/N1/1.txt index fb33923..ba72938 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -11,8 +11,8 @@ David S. Miller wrote: > catch cases that usually end up being bugs. So, how might it tell when someone is mistakenly using a pointer as a boolean if -it takes a pass on if(foo) or if(!foo) instead of looking for if(foo = NULL) -or if(foo != NULL)? (or I suppose if (NULL = foo) and if (NULL != foo)) +it takes a pass on if(foo) or if(!foo) instead of looking for if(foo == NULL) +or if(foo != NULL)? (or I suppose if (NULL == foo) and if (NULL != foo)) it would seem that the compars with NULL, when read by pseudorandom folks would be more likely to reinforce that foo is a pointer rather than a boolean/flag. diff --git a/a/content_digest b/N1/content_digest index 4e6ee11..80b3c74 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,8 +3,8 @@ "ref\020060208.144712.66821895.davem@davemloft.net\0" "From\0Rick Jones <rick.jones2@hp.com>\0" "Subject\0Re: [PATCH] ppp: don't use 0 in pointer context\0" - "Date\0Wed, 08 Feb 2006 23:00:24 +0000\0" - "To\0\0" + "Date\0Wed, 08 Feb 2006 15:00:24 -0800\0" + "To\0unlisted-recipients:; (no To-header on input)\0" "Cc\0linux-ppp@vger.kernel.org" netdev@vger.kernel.org netdev-owner@vger.kernel.org @@ -24,12 +24,12 @@ "> catch cases that usually end up being bugs.\n" "\n" "So, how might it tell when someone is mistakenly using a pointer as a boolean if \n" - "it takes a pass on if(foo) or if(!foo) instead of looking for if(foo = NULL) \n" - "or if(foo != NULL)? (or I suppose if (NULL = foo) and if (NULL != foo))\n" + "it takes a pass on if(foo) or if(!foo) instead of looking for if(foo == NULL) \n" + "or if(foo != NULL)? (or I suppose if (NULL == foo) and if (NULL != foo))\n" "\n" "it would seem that the compars with NULL, when read by pseudorandom folks would \n" "be more likely to reinforce that foo is a pointer rather than a boolean/flag.\n" "\n" rick jones -3b0ec7fd7e3c1b6ee9a5430908c890aee05532d7e603cb9413afbf0fc06b3fd6 +b67cd81e701279eb4b792091fce98b7a96bb4e64ab36d3611455f54651bd20f3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.