All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: brking@us.ibm.com
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [patch 02/15] libata: Add host lock to struct ata_port
Date: Thu, 09 Feb 2006 02:17:31 -0500	[thread overview]
Message-ID: <43EAEC8B.2060003@pobox.com> (raw)
In-Reply-To: <200602061542.k16FgROF014749@d01av03.pok.ibm.com>

brking@us.ibm.com wrote:
> Prepare for changes required to support SATA devices
> attached to SAS HBAs. For these devices we don't want to
> use host_set at all, since libata will not be the owner
> of struct scsi_host.
> 
> Signed-off-by: Brian King <brking@us.ibm.com>

Please move this as far back in the patch series as possible.  The 
simple stuff -- moving code into static functions for later use, for 
example -- should come first.

While you're ginning up the resend, I'll be pondering this and the 
latter portion of your patch series.  This seems like a sane way to go, 
but I want to think a bit more on the overall direction.

	Jeff




      reply	other threads:[~2006-02-09  7:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-06 15:42 [patch 02/15] libata: Add host lock to struct ata_port brking
2006-02-09  7:17 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43EAEC8B.2060003@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=brking@us.ibm.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.