* [KJ] net/pppoe.c: check return code of register_netdevice_notifier
@ 2006-02-09 9:29 walter harms
0 siblings, 0 replies; only message in thread
From: walter harms @ 2006-02-09 9:29 UTC (permalink / raw)
To: kernel-janitors
check return code of register_netdevice_notifier.
do propper cleanup and say goodbye
Signed-off-by: walter harms <wharms@bfs.de>
--- linux/drivers/net/pppoe.c.bak 2006-02-01 22:13:41.000000000 +0100
+++ linux/drivers/net/pppoe.c 2006-02-01 22:16:56.000000000 +0100
@@ -1126,7 +1126,16 @@
dev_add_pack(&pppoes_ptype);
dev_add_pack(&pppoed_ptype);
- register_netdevice_notifier(&pppoe_notifier);
+
+ err = register_netdevice_notifier(&pppoe_notifier);
+ if (err < 0) {
+ printk( KERN_WARNING "register_netdevice_notifier failed in
%s\n",__FUNCTION__);
+ dev_remove_pack(&pppoed_ptype);
+ dev_remove_pack(&pppoes_ptype);
+ goto out_unregister_pppox_proto;
+ }
+
+
out:
return err;
out_unregister_pppox_proto:
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-02-09 9:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-09 9:29 [KJ] net/pppoe.c: check return code of register_netdevice_notifier walter harms
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.