From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] net/hamradio/bpqether.c: check the return code of
Date: Thu, 09 Feb 2006 09:38:50 +0000 [thread overview]
Message-ID: <43EB0DAA.1060300@bfs.de> (raw)
check the return code of register_netdevice_notifier.
fix for the last patch. now it removes the proc entry also.
Signed-off-by: walter harms <wharms@bfs.de>
--- linux/drivers/net/hamradio/bpqether.c.bak 2006-02-01
22:13:07.000000000 +0100
+++ linux/drivers/net/hamradio/bpqether.c 2006-02-06 22:10:24.819769200
+0100
@@ -595,6 +595,7 @@
*/
static int __init bpq_init_driver(void)
{
+ int ret;
#ifdef CONFIG_PROC_FS
if (!proc_net_fops_create("bpqether", S_IRUGO, &bpq_info_fops)) {
printk(KERN_ERR
@@ -605,7 +606,13 @@
dev_add_pack(&bpq_packet_type);
- register_netdevice_notifier(&bpq_dev_notifier);
+ ret = register_netdevice_notifier(&bpq_dev_notifier);
+ if (ret < 0) {
+ printk( KERN_ERR "register_netdevice_notifier failed in
%s\n",__FUNCTION__);
+ dev_remove_pack(&bpq_packet_type);
+ proc_net_remove("bpqether");
+ return -1;
+ }
printk(banner);
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2006-02-09 9:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43EB0DAA.1060300@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.