From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] net/wan/lapbether.c:check return code of
Date: Thu, 09 Feb 2006 09:46:11 +0000 [thread overview]
Message-ID: <43EB0F63.1090706@bfs.de> (raw)
hi all,
if the patches for bond_main.c,bpqether.c,dlci.c,lapbether.c and
pppoe.c are applied no more uncecked register_netdevice_notifier()
should be exist. i did a test compile with all patches and found no
ill effects.
check return code of register_netdevice_notifier.
Signed-off-by: walter harms <wharms@bfs.de>
--- linux/drivers/net/wan/lapbether.c.bak 2006-02-01 22:09:28.000000000
+0100
+++ linux/drivers/net/wan/lapbether.c 2006-02-01 22:14:41.000000000 +0100
@@ -432,9 +432,15 @@
static int __init lapbeth_init_driver(void)
{
+ int ret;
dev_add_pack(&lapbeth_packet_type);
- register_netdevice_notifier(&lapbeth_dev_notifier);
+ ret = register_netdevice_notifier(&lapbeth_dev_notifier);
+ if (ret < 0) {
+ printk( KERN_WARNING "register_netdevice_notifier failed in
%s\n",__FUNCTION__);
+ dev_remove_pack(&lapbeth_packet_type);
+ return -1;
+ }
printk(banner);
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2006-02-09 9:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43EB0F63.1090706@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.