Re: [PATCH] ahci: separate out ahci_fill_cmd_slot()

[Jeff Garzik <jgarzik@pobox.com>]

Tejun Heo wrote:
> Separate out ahci_fill_cmd_slot() from ahci_qc_prep().
> ahci_fill_cmd_slot() can later be used to issue non-standard commands.
> (e.g. softreset)
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>

applied, with comment:

> +static void ahci_fill_cmd_slot(struct ata_port *ap, u32 opts)
> +{
> +	struct ahci_port_priv *pp = ap->private_data;
> +	pp->cmd_slot[0].opts = cpu_to_le32(opts);
> +	pp->cmd_slot[0].status = 0;
> +	pp->cmd_slot[0].tbl_addr = cpu_to_le32(pp->cmd_tbl_dma & 0xffffffff);
> +	pp->cmd_slot[0].tbl_addr_hi = cpu_to_le32((pp->cmd_tbl_dma >> 16) >> 16);
> +}

Probably should just pass 'pp' directly to ahci_fill_cmd_slot() as an 
argument, rather than 'ap'.

	Jeff