From: Dirk Behme <dirk.behme@googlemail.com>
To: "Juha Yrjölä" <juha.yrjola@nokia.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] Convert drivers to new irq trigger modes
Date: Sun, 12 Feb 2006 16:43:12 +0100 [thread overview]
Message-ID: <43EF5790.3020509@gmail.com> (raw)
In-Reply-To: <20060209062536.GC11799@two.research.nokia.com>
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
Juha Yrjölä wrote:
> SA_SAMPLE_RANDOM doesn't have anything to do with triggering. It's used to
> indicate whether an IRQ source can be used to feed the kernel entropy pools.
> If the IRQ in question cannot be considered to happen at random intervals,
> the flag must not be set.
Okay. What's about this?
Add ORing the SA_TRIGGER_FALLING and don't use
SA_SAMPLE_RANDOM as default value in ts_inn1510.c.
[-- Attachment #2: sample_random_patch.txt --]
[-- Type: text/plain, Size: 1713 bytes --]
--- ./drivers/i2c/chips/isp1301_omap.c_orig 2006-02-12 16:31:26.000000000 +0100
+++ ./drivers/i2c/chips/isp1301_omap.c 2006-02-12 16:36:13.000000000 +0100
@@ -1604,7 +1604,7 @@ fail1:
isp->irq = OMAP_GPIO_IRQ(2);
omap_request_gpio(2);
omap_set_gpio_direction(2, 1);
- isp->irq_type = SA_TRIGGER_FALLING;
+ isp->irq_type |= SA_TRIGGER_FALLING;
}
if (machine_is_omap_h3()) {
@@ -1613,7 +1613,7 @@ fail1:
isp->irq = OMAP_GPIO_IRQ(14);
omap_request_gpio(14);
omap_set_gpio_direction(14, 1);
- isp->irq_type = SA_TRIGGER_FALLING;
+ isp->irq_type |= SA_TRIGGER_FALLING;
}
status = request_irq(isp->irq, isp1301_irq,
--- ./drivers/i2c/chips/tps65010.c_orig 2006-02-12 16:33:21.000000000 +0100
+++ ./drivers/i2c/chips/tps65010.c 2006-02-12 16:34:38.000000000 +0100
@@ -536,7 +536,7 @@ fail1:
tps->irq = OMAP_GPIO_IRQ(58);
omap_request_gpio(58);
omap_set_gpio_direction(58, 1);
- tps->irq_type = SA_TRIGGER_FALLING;
+ tps->irq_type |= SA_TRIGGER_FALLING;
}
if (machine_is_omap_osk()) {
tps->model = TPS65010;
@@ -544,7 +544,7 @@ fail1:
tps->irq = OMAP_GPIO_IRQ(OMAP_MPUIO(1));
omap_request_gpio(OMAP_MPUIO(1));
omap_set_gpio_direction(OMAP_MPUIO(1), 1);
- tps->irq_type = SA_TRIGGER_FALLING;
+ tps->irq_type |= SA_TRIGGER_FALLING;
}
if (machine_is_omap_h3()) {
tps->model = TPS65013;
--- ./drivers/input/touchscreen/omap/ts_inn1510.c_orig 2006-02-12 16:37:04.000000000 +0100
+++ ./drivers/input/touchscreen/omap/ts_inn1510.c 2006-02-12 16:37:18.000000000 +0100
@@ -176,7 +176,7 @@ static int __init inn1510_ts_probe(struc
return -ENODEV;
ts->irq = OMAP1510_INT_FPGA_TS;
- ts->irq_type = SA_SAMPLE_RANDOM;
+ ts->irq_type = 0;
return 0;
}
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2006-02-12 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-07 17:32 [PATCH] Convert drivers to new irq trigger modes Dirk Behme
2006-02-07 23:16 ` Tony Lindgren
2006-02-08 5:14 ` Juha Yrjölä
2006-02-08 19:10 ` Dirk Behme
2006-02-09 6:25 ` Juha Yrjölä
2006-02-12 15:43 ` Dirk Behme [this message]
2006-02-13 9:17 ` Juha Yrjölä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43EF5790.3020509@gmail.com \
--to=dirk.behme@googlemail.com \
--cc=juha.yrjola@nokia.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.