From: "Seewer Philippe" <philippe.seewer@bfh.ch>
To: jgarzik@pobox.com
Cc: linux-ide@vger.kernel.org
Subject: [PATCH] pdc_adma: Last Patch to pdc_adma breaks debug compile[Scanned]
Date: Mon, 13 Feb 2006 09:33:40 +0100 [thread overview]
Message-ID: <43F04464.3020300@bfh.ch> (raw)
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
The Last Patch (5. Nov. 05) to the sata pdc_adma driver removed nelem
from adma_fill_sg and introduced ata_for_each_sg.
The Problem is that nelem was forgot to be removed from the contained
VPRINTK too. The attached patch fixes this.
Patch applies against 2.6.15.1
Signed-Off-By: Seewer Philippe <philippe.seewer@bfh.ch>
---
--- linux-2.6.15.1/drivers/scsi/pdc_adma.c.orig 2006-02-08
09:03:15.000000000 +0100
+++ linux-2.6.15.1/drivers/scsi/pdc_adma.c 2006-02-08
09:04:32.000000000 +0100
@@ -322,8 +322,8 @@ static int adma_fill_sg(struct ata_queue
= (pFLAGS & pEND) ? 0 : cpu_to_le32(pp->pkt_dma
+ i + 4);
i += 4;
- VPRINTK("PRD[%u] = (0x%lX, 0x%X)\n", nelem
- (unsigned long)addr, len);
+ VPRINTK("Current PRD = (0x%lX, 0x%X)\n",
+ (unsigned long)addr, len);
}
return i;
}
[-- Attachment #2: pdc_adma.patch --]
[-- Type: text/x-patch, Size: 473 bytes --]
--- linux-2.6.15.1/drivers/scsi/pdc_adma.c.orig 2006-02-08 09:03:15.000000000 +0100
+++ linux-2.6.15.1/drivers/scsi/pdc_adma.c 2006-02-08 09:04:32.000000000 +0100
@@ -322,8 +322,8 @@ static int adma_fill_sg(struct ata_queue
= (pFLAGS & pEND) ? 0 : cpu_to_le32(pp->pkt_dma + i + 4);
i += 4;
- VPRINTK("PRD[%u] = (0x%lX, 0x%X)\n", nelem
- (unsigned long)addr, len);
+ VPRINTK("Current PRD = (0x%lX, 0x%X)\n",
+ (unsigned long)addr, len);
}
return i;
}
reply other threads:[~2006-02-13 8:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F04464.3020300@bfh.ch \
--to=philippe.seewer@bfh.ch \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.