From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [RFC][LIBNFNETLINK 3/3] API changes Date: Mon, 13 Feb 2006 22:13:00 +0100 Message-ID: <43F0F65C.7030604@eurodev.net> References: <43EFAB2A.4030204@eurodev.net> <20060213114452.GY4601@sunbeam.de.gnumonks.org> <43F0A945.4010902@ufomechanic.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Harald Welte , Netfilter Development Mailinglist , Patrick McHardy Return-path: To: Amin Azez In-Reply-To: <43F0A945.4010902@ufomechanic.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Amin Azez wrote: > AFAIR, done is not required unless we are trying to copy someone else > api type. > > 3 types of return values were permitted, <0, 0 and >0, by the function > which now has "done" added. 0 meant continue, either <0 or >0 meant > "stop now" and the other meant "stop after all messages in the currently > read packet", it's hard to see how this doesn't provide what done > provided; even with 2 values. Two kind of messages that mean "stop now" can make nfnl_handle_packet return 0. a) ACK messages: When the client request some information with the NLM_F_ACK flag set. b) DONE messages: At dumping, the last message received has the NLM_F_MULTI flag set (NLMSG_DONE) to notify that the dumping has finished. -- Pablo