From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "Michael S. Tsirkin" <mst@mellanox.co.il>
Cc: Andrew Morton <akpm@osdl.org>, Hugh Dickins <hugh@veritas.com>,
William Irwin <wli@holomorphy.com>,
Roland Dreier <rdreier@cisco.com>,
Gleb Natapov <gleb@minantech.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
openib-general@openib.org, Petr Vandrovec <vandrove@vc.cvut.cz>,
Badari Pulavarty <pbadari@us.ibm.com>,
Grant Grundler <grundler@parisc-linux.org>,
Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH] madvise MADV_DONTFORK/MADV_DOFORK
Date: Wed, 15 Feb 2006 15:31:42 +1100 [thread overview]
Message-ID: <43F2AEAE.5010700@yahoo.com.au> (raw)
In-Reply-To: <20060213233517.GG13603@mellanox.co.il>
Michael S. Tsirkin wrote:
> Index: linux-2.6.16-rc2/include/asm-x86_64/mman.h
> ===================================================================
> --- linux-2.6.16-rc2.orig/include/asm-x86_64/mman.h 2006-02-14 01:22:27.000000000 +0200
> +++ linux-2.6.16-rc2/include/asm-x86_64/mman.h 2006-02-14 01:24:57.000000000 +0200
> @@ -37,6 +37,8 @@
> #define MADV_WILLNEED 0x3 /* pre-fault pages */
> #define MADV_DONTNEED 0x4 /* discard these pages */
> #define MADV_REMOVE 0x5 /* remove these pages & resources */
> +#define MADV_DONTFORK 0x30 /* dont inherit across fork */
> +#define MADV_DOFORK 0x31 /* do inherit across fork */
>
May I ask, what is the rationale for ignoring the apparent conventions
of all architectures? For example parisc, you appear to even go contrary
to the comment.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-02-15 4:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 15:41 madvise MADV_DONTFORK/MADV_DOFORK Michael S. Tsirkin
2006-02-13 18:23 ` Hugh Dickins
2006-02-13 19:02 ` Michael S. Tsirkin
2006-02-14 6:51 ` Gleb Natapov
2006-02-13 19:04 ` [openib-general] " Roland Dreier
2006-02-13 19:05 ` Linus Torvalds
2006-02-13 19:16 ` [openib-general] " Roland Dreier
2006-02-13 19:34 ` Linus Torvalds
2006-02-13 19:50 ` Hugh Dickins
2006-02-13 21:09 ` Michael S. Tsirkin
2006-02-13 21:57 ` Hugh Dickins
2006-02-13 22:09 ` Michael S. Tsirkin
2006-02-13 22:54 ` Hugh Dickins
2006-02-13 23:01 ` [PATCH] " Michael S. Tsirkin
2006-02-13 23:44 ` Hugh Dickins
2006-02-13 22:27 ` [openib-general] " Linus Torvalds
2006-02-13 22:55 ` Michael S. Tsirkin
2006-02-13 23:01 ` Hugh Dickins
2006-02-13 23:35 ` [PATCH] " Michael S. Tsirkin
2006-02-15 4:31 ` Nick Piggin [this message]
2006-02-15 6:09 ` Roland Dreier
2006-02-15 6:16 ` Andrew Morton
2006-02-15 6:34 ` [PATCH] Fix up MADV_DONTFORK/MADV_DOFORK definitions Roland Dreier
2006-02-15 6:48 ` Gleb Natapov
2006-02-15 7:06 ` Nick Piggin
2006-02-15 7:31 ` Bernd Eckenfels
2006-02-15 8:18 ` Michael S. Tsirkin
2006-02-15 8:13 ` [PATCH] madvise MADV_DONTFORK/MADV_DOFORK Michael S. Tsirkin
2006-02-13 20:05 ` Michael S. Tsirkin
2006-02-13 19:20 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F2AEAE.5010700@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=gleb@minantech.com \
--cc=grundler@parisc-linux.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mst@mellanox.co.il \
--cc=openib-general@openib.org \
--cc=pbadari@us.ibm.com \
--cc=rdreier@cisco.com \
--cc=vandrove@vc.cvut.cz \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.