Re: TASKFILE ioctl for libata?

[Jeff Garzik <jgarzik@pobox.com>]

Erik Mouw wrote:
> On Wed, Feb 15, 2006 at 02:00:46PM -0500, Mark Lord wrote:
> 
>>Erik Mouw wrote:
>>
>>>Hdparm (6.3) needs the TASKFILE ioctl for the ATA security feature set
>>>(security freeze, security unlock, etc.). I can't find it in Jeff's
>>>libata-dev tree, is there somebody already working on it? Or is there a
>>>workaround?
>>
>>If that ioctl is missing in libata, then I'll have to convert hdparm
>>to use SGIO to submit ATA Passthru packets instead for libata devices.
> 
> 
> If SGIO can be used for ATA Passthru, then why are the HDIO_DRIVE_CMD
> and HDIO_DRIVE_TASK ioctl()s implemented in libata? AFAICS, the same
> functionality can be accomplished through SGIO ATA Passthru.

For compatibility :)  The HDIO compat ioctls are implemented internally 
via the ATA passthru SCSI command.

Although in general I resist adding compat ioctls, I think avoiding 
TASKFILE when we have TASK/CMD ioctls would be inconsistent.  If 
somebody wants to submit a tested patch...

	Jeff