From: Nick Piggin <nickpiggin@yahoo.com.au>
To: NeilBrown <neilb@suse.de>, Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, Nick Piggin <npiggin@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix over-zealous tag clearing in radix_tree_delete
Date: Thu, 16 Feb 2006 17:05:53 +1100 [thread overview]
Message-ID: <43F41641.5080601@yahoo.com.au> (raw)
In-Reply-To: <1060216034301.11136@suse.de>
NeilBrown wrote:
> Against 2.6.16-rc2-mm1. For inclusion in 2.6.16 please.
>
> ### Comments for Changeset
>
> If a tag is set for a node being deleted from a radix_tree,
> then that tag gets cleared from the parent of the node, even
> if it is set for some siblings of the node begin deleted.
>
> This patch changes the logic to include a test for any_tag_set similar
> to the logic a little futher down. Care is taken to ensure that
> 'nr_cleared_tags' remains equals to the number of entries in the
> 'tags' array which are set to '0' (which means that this tag is not
> set in the tree below pathp->node, and should be cleared at
> pathp->node and possibly above.
>
> Acked-by: Nick Piggin <npiggin@suse.de>
> Signed-off-by: Neil Brown <neilb@suse.de>
>
Linus FYI, I was able to modify the radix tree test harness to catch
the bug and can no longer trigger it after the fix. Resulting code
passes all other harness tests as well of course.
Should be applied ASAP. However, unlike Andrew I don't think this is
a filesystem corrupting bug (maybe he was talking about NFS?).
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
prev parent reply other threads:[~2006-02-16 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060216144112.11116.patches@notabene>
2006-02-16 3:43 ` [PATCH] Fix over-zealous tag clearing in radix_tree_delete NeilBrown
2006-02-16 6:05 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F41641.5080601@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=npiggin@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.