From: Patrick McHardy <kaber@trash.net>
To: Harald Welte <laforge@netfilter.org>
Cc: Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>,
Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH 4/4] first conntrack ID must be 1 not 2
Date: Thu, 16 Feb 2006 09:33:57 +0100 [thread overview]
Message-ID: <43F438F5.8070607@trash.net> (raw)
In-Reply-To: <20060213112028.GU4601@sunbeam.de.gnumonks.org>
Harald Welte wrote:
> On Mon, Feb 13, 2006 at 03:41:52AM +0100, Pablo Neira Ayuso wrote:
>
>>[NF_CONNTRACK] first conntrack ID must be 1 not 2
>>
>>The first conntrack ID must be 1. If a new conntrack is created, the
>>general ID counter must be post-incremented instead pre-incremented
>>since [ip|nf]_conntrack_next_id is initialized to 1. Same applies for
>>expectations.
>
>
> looks clean to me. Interesting question though: Does it matter whether
> we start with 1 or 2? Am I missing something?
Its irrelevant since the number doesn't have any meaning beyond beeing
an identifier. Anyway, I'd prefer a patch that just removes the
initialization to 1.
next prev parent reply other threads:[~2006-02-16 8:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 2:41 [PATCH 4/4] first conntrack ID must be 1 not 2 Pablo Neira Ayuso
2006-02-13 11:20 ` Harald Welte
2006-02-16 8:33 ` Patrick McHardy [this message]
2006-02-16 8:47 ` Jozsef Kadlecsik
2006-02-16 9:02 ` Patrick McHardy
2006-02-16 9:11 ` Jozsef Kadlecsik
2006-02-16 9:14 ` Patrick McHardy
2006-02-16 9:36 ` Jozsef Kadlecsik
2006-02-16 20:09 ` Patrick McHardy
2006-02-17 8:18 ` Jozsef Kadlecsik
2006-02-17 8:45 ` Martin Josefsson
2006-02-17 9:30 ` Jozsef Kadlecsik
2006-02-17 18:41 ` Jozsef Kadlecsik
2006-03-04 16:23 ` Hashtrie testing (was: Re: [PATCH 4/4] first conntrack ID must be 1 not 2) Martin Josefsson
2006-03-05 9:49 ` Jozsef Kadlecsik
2006-03-05 13:24 ` Martin Josefsson
2006-03-04 20:11 ` Hashtrie testing2 " Martin Josefsson
2006-03-05 11:24 ` Jozsef Kadlecsik
2006-03-05 17:48 ` Martin Josefsson
2006-03-06 13:15 ` Jozsef Kadlecsik
2006-03-07 18:33 ` Martin Josefsson
2006-03-08 6:34 ` Patrick Schaaf
2006-03-12 18:49 ` Martin Josefsson
2006-03-14 11:35 ` Jozsef Kadlecsik
2006-03-23 11:27 ` Jozsef Kadlecsik
2006-03-23 21:07 ` Martin Josefsson
2006-03-25 8:39 ` Jozsef Kadlecsik
2006-03-28 12:26 ` Jozsef Kadlecsik
2006-03-30 8:28 ` Hashtrie testing2, dancing trees Amin Azez
2006-03-31 18:43 ` Jozsef Kadlecsik
2006-02-17 8:50 ` [PATCH 4/4] first conntrack ID must be 1 not 2 Patrick McHardy
2006-03-30 8:31 ` Amin Azez
2006-03-31 1:11 ` Patrick McHardy
2006-03-31 18:35 ` Jozsef Kadlecsik
2006-03-31 18:44 ` Patrick McHardy
2006-04-01 19:31 ` Harald Welte
2006-04-06 11:02 ` Patrick McHardy
2006-04-11 16:09 ` Amin Azez
2006-04-11 16:17 ` Patrick McHardy
[not found] ` <443CA579.3030908@ufomechanic.net>
2006-04-12 18:30 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F438F5.8070607@trash.net \
--to=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=pablo@netfilter.org \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.