All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: x86_64 eth0 e1000_clean_tx_irq tx hang
Date: Thu, 16 Feb 2006 12:45:19 +0100	[thread overview]
Message-ID: <43F473DF.76F0.0078.0@novell.com> (raw)
In-Reply-To: <897ee454c188d55c2fa64769aa722317@cl.cam.ac.uk>

>>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 16.02.06 12:36:29 >>>
>
>On 16 Feb 2006, at 03:07, Chris Wright wrote:
>
>> Here's a quick patch that fixes the issue (not ready to apply to
>> -unstable, since it's a file that's not in sparse tree).  Nitin, this
>> should fix your problem as well.  I'll work on a proper patch later 
>> this
>> evening or tomorrow morning.
>
>Thanks for tracking this one down: it's been our major outstanding bug 
>for a while now. We checked in a suitable fix to -unstable (change 
>pci-dma-xen.c to explicitly include the asm-i386/mach-xen version of 
>swiotlb.h).

This doesn't sound like a good thing to do, as that way all but this one file will include the x86-64 version of it,
and you can easily get things out of sync (if e.g. the x86-64 version changes). I would much favor the change being done
as originally posted; we have a similar same fix in our tree.

Jan

  reply	other threads:[~2006-02-16 11:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-09 23:55 x86_64 eth0 e1000_clean_tx_irq tx hang Kamble, Nitin A
2006-02-10 11:20 ` Keir Fraser
2006-02-10 11:33   ` Muli Ben-Yehuda
2006-02-16  3:07 ` Chris Wright
2006-02-16 11:36   ` Keir Fraser
2006-02-16 11:45     ` Jan Beulich [this message]
2006-02-16 13:54       ` Keir Fraser
2006-02-16 13:10   ` Guillaume Thouvenin
2006-02-16 13:55     ` Keir Fraser
2006-02-17  7:26       ` Guillaume Thouvenin
  -- strict thread matches above, loose matches on Subject: below --
2006-02-09  2:29 Ian Pratt
2006-02-09  1:50 Ian Pratt
2006-02-09  1:59 ` Chris Wright
2006-02-09  2:29 ` Chris Wright
2006-02-09  1:29 Ian Pratt
2006-02-09  1:38 ` Chris Wright
2006-02-09  1:49 ` Chris Wright
2006-02-08 23:36 Ian Pratt
2006-02-09  1:27 ` Chris Wright
2006-02-09 15:02 ` Christian Leber
2006-02-09 17:24   ` Chris Wright
2006-02-09 23:29     ` Christian Leber
2006-02-08 20:01 Ian Pratt
2006-02-08 20:11 ` Chris Wright
2006-02-08 15:06 Adam Wendt
2006-02-07 20:47 Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43F473DF.76F0.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.