From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: x86_64 eth0 e1000_clean_tx_irq tx hang Date: Thu, 16 Feb 2006 12:45:19 +0100 Message-ID: <43F473DF.76F0.0078.0@novell.com> References: <20060216030715.GK3490@sorel.sous-sol.org> <897ee454c188d55c2fa64769aa722317@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <897ee454c188d55c2fa64769aa722317@cl.cam.ac.uk> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> Keir Fraser 16.02.06 12:36:29 >>> > >On 16 Feb 2006, at 03:07, Chris Wright wrote: > >> Here's a quick patch that fixes the issue (not ready to apply to >> -unstable, since it's a file that's not in sparse tree). Nitin, this >> should fix your problem as well. I'll work on a proper patch later >> this >> evening or tomorrow morning. > >Thanks for tracking this one down: it's been our major outstanding bug >for a while now. We checked in a suitable fix to -unstable (change >pci-dma-xen.c to explicitly include the asm-i386/mach-xen version of >swiotlb.h). This doesn't sound like a good thing to do, as that way all but this one file will include the x86-64 version of it, and you can easily get things out of sync (if e.g. the x86-64 version changes). I would much favor the change being done as originally posted; we have a similar same fix in our tree. Jan