All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: jgarzik@pobox.com
Cc: albertcc@tw.ibm.com, alan@lxorguk.ukuu.org.uk,
	bzolnier@gmail.com, linux-ide@vger.kernel.org
Subject: Re: [PATCHSET] libata: use single unsigned int xfer_mask
Date: Thu, 16 Feb 2006 23:27:05 +0900	[thread overview]
Message-ID: <43F48BB9.5080100@gmail.com> (raw)
In-Reply-To: <11400989462656-git-send-email-htejun@gmail.com>

Oops, I forgot to write about the following notes.

* In the second patch, some of ATA_UDMA_MASK_40C usages are converted to 
ata_xfer_*() helper usages with ATA_SHIFT_UDMA and explicit maximum mode 
number 2 as arguments.  Also, ATA_UDMAn and ATA_UDMA_MASK_40C macros are 
very lightly used.  Something can be done about these constants, I think.

* In the second patch, ata_timing_comput() is left to use XFER_* values 
as arguments and for calculation purposes.  As this function has no 
in-tree user yet, I couldn't determine how to transform it.  It's also 
quite possible that simply continuing to use XFER_* values are okay.

Thanks.

-- 
tejun

  reply	other threads:[~2006-02-16 14:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-15 12:53 regarding xfer mode representation in dev, ap and other places Tejun Heo
2006-02-16 14:09 ` [PATCH 1/3] libata: fix sata_sil24 mwdma_mask setting Tejun Heo
2006-02-16 14:09 ` [PATCHSET] libata: use single unsigned int xfer_mask Tejun Heo
2006-02-16 14:27   ` Tejun Heo [this message]
2006-02-16 14:46     ` Alan Cox
2006-02-16 14:09 ` [PATCH 3/3] libata: make ata_port_info and ata_probe_ent use xfer_mask Tejun Heo
2006-02-16 14:09 ` [PATCH 2/3] libata: make ata_device and ata_port use unsigned int xfer_mask Tejun Heo
2006-02-16 14:32   ` Alan Cox
2006-02-16 15:01     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43F48BB9.5080100@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=albertcc@tw.ibm.com \
    --cc=bzolnier@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.