All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Harald Welte <laforge@netfilter.org>
Cc: Netfilter Development Mailinglist
	<netfilter-devel@lists.netfilter.org>,
	Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp>,
	Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH 1/4] Fix expectaction mask dumping, take #3
Date: Thu, 16 Feb 2006 21:11:01 +0100	[thread overview]
Message-ID: <43F4DC55.8030405@trash.net> (raw)
In-Reply-To: <20060216100504.GI15587@sunbeam.de.gnumonks.org>

Harald Welte wrote:
> On Thu, Feb 16, 2006 at 10:36:20AM +0100, Patrick McHardy wrote:
> 
> 
>>I'm not sure I understand. The new attribute still contains the same
>>value as the netlink header, doesn't it? So userspace should currently
>>have at least two possibilities to get the correct value:
>>
>>- use the value from the netlink header
>>- use the value from the tuple that comes with the mask, as the first
>>  part of your patch does. This seems most logically to me since the
>>  mask and the tuple belong together.
> 
> 
> I still dream about a connection with one end in ipv4 space and the
> other in ipv6.  If we ever want to cover such a model, then the tuple
> needs to include l3num.

Yes, but until then it looks totally redundant. Since the bandwidth
of netlink is limited, I think we shouldn't add new attributes without
really needing them.

  reply	other threads:[~2006-02-16 20:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-13  2:39 [PATCH 1/4] Fix expectaction mask dumping, take #3 Pablo Neira Ayuso
2006-02-13 11:13 ` Harald Welte
2006-02-16  9:36 ` Patrick McHardy
2006-02-16 10:05   ` Harald Welte
2006-02-16 20:11     ` Patrick McHardy [this message]
2006-02-21 12:16       ` Yasuyuki KOZAKAI
     [not found]       ` <200602211216.k1LCG18I024522@toshiba.co.jp>
2006-02-23  9:43         ` Patrick McHardy
2006-02-23 10:10           ` Yasuyuki KOZAKAI
2006-02-21 13:03   ` Pablo Neira Ayuso
2006-02-22  3:20     ` Pablo Neira Ayuso
2006-02-22 13:01       ` Yasuyuki KOZAKAI
     [not found]       ` <200602221301.k1MD1lIb015798@toshiba.co.jp>
2006-02-23  9:48         ` Patrick McHardy
2006-02-23 11:10           ` Yasuyuki KOZAKAI
     [not found]           ` <200602231110.k1NBA71v013563@toshiba.co.jp>
2006-02-23 11:13             ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43F4DC55.8030405@trash.net \
    --to=kaber@trash.net \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=pablo@netfilter.org \
    --cc=yasuyuki.kozakai@toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.