From: "Seewer Philippe" <philippe.seewer@bfh.ch>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sym53c8xx_2: Add bios_param to sym_glue.c
Date: Fri, 17 Feb 2006 15:41:27 +0100 [thread overview]
Message-ID: <43F5E097.4080709@bfh.ch> (raw)
In-Reply-To: <20060217143718.GS12822@parisc-linux.org>
Matthew Wilcox wrote:
> On Fri, Feb 17, 2006 at 03:10:43PM +0100, Seewer Philippe wrote:
>
>>This patch adds the scsi common function bios_param to the sym53c8xx
>>driver. For simplicity i just copied the code from the sym53c416 driver.
>
>
> If the driver doesn't define bios_param, the scsi core calls
> scsicam_bios_param, which seems to do everything this patch does,
> and more.
>
> A quick survey suggests that most drivers should have their bios_param
> methods deleted. Was there a particular problem you found with the
> default scsicam_bios_param implementation?
Yes. Using scsicam_bios_parm and other defaults result in a geometry of
64 heads and 32 sectors even for big disks, which is not what the pc bios
"gets" from the controller. That is more along the lines of 255/63.
Returning a geometry of x/255/63 seems to be the default for bigger disks
withing scsi drivers, so i just copied the code...
WARNING: multiple messages have this Message-ID (diff)
From: "Seewer Philippe" <philippe.seewer@bfh.ch>
To: "Matthew Wilcox" <matthew@wil.cx>
Cc: <linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] sym53c8xx_2: Add bios_param to sym_glue.c
Date: Fri, 17 Feb 2006 15:41:27 +0100 [thread overview]
Message-ID: <43F5E097.4080709@bfh.ch> (raw)
In-Reply-To: <20060217143718.GS12822@parisc-linux.org>
Matthew Wilcox wrote:
> On Fri, Feb 17, 2006 at 03:10:43PM +0100, Seewer Philippe wrote:
>
>>This patch adds the scsi common function bios_param to the sym53c8xx
>>driver. For simplicity i just copied the code from the sym53c416 driver.
>
>
> If the driver doesn't define bios_param, the scsi core calls
> scsicam_bios_param, which seems to do everything this patch does,
> and more.
>
> A quick survey suggests that most drivers should have their bios_param
> methods deleted. Was there a particular problem you found with the
> default scsicam_bios_param implementation?
Yes. Using scsicam_bios_parm and other defaults result in a geometry of
64 heads and 32 sectors even for big disks, which is not what the pc bios
"gets" from the controller. That is more along the lines of 255/63.
Returning a geometry of x/255/63 seems to be the default for bigger disks
withing scsi drivers, so i just copied the code...
next prev parent reply other threads:[~2006-02-17 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-17 14:10 [PATCH] sym53c8xx_2: Add bios_param to sym_glue.c Seewer Philippe
2006-02-17 14:10 ` Seewer Philippe
2006-02-17 14:37 ` Matthew Wilcox
2006-02-17 14:41 ` Seewer Philippe [this message]
2006-02-17 14:41 ` Seewer Philippe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F5E097.4080709@bfh.ch \
--to=philippe.seewer@bfh.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.