From: Mark Lord <liml@rtr.ca>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: ide <linux-ide@vger.kernel.org>, jgarzik <jgarzik@pobox.com>
Subject: Re: [PATCH] rate-limit libata-scsi status/error message
Date: Sat, 18 Feb 2006 09:13:04 -0500 [thread overview]
Message-ID: <43F72B70.5040107@rtr.ca> (raw)
In-Reply-To: <20060217213733.36040150.rdunlap@xenotime.net>
Randy.Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Rate-limit a translated ATA status/error message.
> I have a kernel log that is 2/3 full of these messages
> due to a CD/DVD drive being empty.
...
> - printk(KERN_ERR "ata%u: translated ATA stat/err 0x%02x/%02x to "
> - "SCSI SK/ASC/ASCQ 0x%x/%02x/%02x\n", id, drv_stat, drv_err,
> - *sk, *asc, *ascq);
> + if (printk_ratelimit())
> + printk(KERN_ERR "ata%u: translated ATA stat/err 0x%02x/%02x to "
> + "SCSI SK/ASC/ASCQ 0x%x/%02x/%02x\n",
> + id, drv_stat, drv_err, *sk, *asc, *ascq);
That message shouldn't even be enabled for non DEBUG cases.
I suspect Jeff will remove it for 2.6.17..
-ml
next prev parent reply other threads:[~2006-02-18 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-18 5:37 [PATCH] rate-limit libata-scsi status/error message Randy.Dunlap
2006-02-18 14:13 ` Mark Lord [this message]
2006-03-01 20:43 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43F72B70.5040107@rtr.ca \
--to=liml@rtr.ca \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.