All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@tv-sign.ru>
To: paulmck@us.ibm.com
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, Roland McGrath <roland@redhat.com>,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2/2] fix kill_proc_info() vs fork() theoretical race
Date: Sat, 18 Feb 2006 21:19:36 +0300	[thread overview]
Message-ID: <43F76538.16BBA317@tv-sign.ru> (raw)
In-Reply-To: 20060218020659.GH1291@us.ibm.com

"Paul E. McKenney" wrote:
> 
> On Fri, Feb 17, 2006 at 12:20:08AM +0300, Oleg Nesterov wrote:
> > "Paul E. McKenney" wrote:
> > >
> > > The other thing to think through is tkill on a thread/process while it
> > > is being created.  I believe that this is OK, since thread-specific
> > > kill must target a specific thread, so does not do the traversal.
> >
> > Also, tkill was not converted to use rcu_read_lock yet, it still
> > takes tasklist_lock, so I think it is safe.
> 
> I suspect that tkill will eventually need to avoid tasklist_lock...  ;-)

Ok, I am sending a couple of preparation patches for this.

Paul, I didn't beleive you when you started this work. Now I think
we can avoid tasklist AND cleanup the code in many places. I am glad
I was wrong.

Btw,
>
> firing off some steamroller tests on it.

Could you point me to these tests?

Oleg.

  reply	other threads:[~2006-02-18 17:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-06 16:45 [PATCH] fix kill_proc_info() vs copy_process() race Oleg Nesterov
2006-02-06 17:10 ` Oleg Nesterov
2006-02-06 20:25   ` Oleg Nesterov
2006-02-14 22:32 ` Paul E. McKenney
2006-02-15 14:05   ` Oleg Nesterov
2006-02-15 19:13     ` [PATCH 1/2] fix kill_proc_info() vs CLONE_THREAD race Oleg Nesterov
2006-02-16 19:19       ` Paul E. McKenney
2006-02-16 21:16         ` Oleg Nesterov
2006-02-15 19:13     ` [PATCH 2/2] fix kill_proc_info() vs fork() theoretical race Oleg Nesterov
2006-02-16 19:26       ` Paul E. McKenney
2006-02-16 20:56         ` Oleg Nesterov
2006-02-16 19:53           ` Paul E. McKenney
2006-02-16 21:20             ` Oleg Nesterov
2006-02-18  2:06               ` Paul E. McKenney
2006-02-18 18:19                 ` Oleg Nesterov [this message]
2006-02-20 17:49                   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43F76538.16BBA317@tv-sign.ru \
    --to=oleg@tv-sign.ru \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@us.ibm.com \
    --cc=roland@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.