All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rimas Kudelis <rq@akl.lt>
To: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: [PATCH] hda/alc260: tweak test model input mux labels, fix a comment
Date: Mon, 20 Feb 2006 07:36:08 +0200	[thread overview]
Message-ID: <43F95548.1000805@akl.lt> (raw)
In-Reply-To: <200602200017.k1K0HiRP021736@auster.physics.adelaide.edu.au>

Jonathan,

I think you forgot to add ", 0x7" to the last line in the list.

Rimas


> +/* This is a bit messy since the two input muxes in the ALC260 have slight
> + * variations in their signal assignments.  The ideal way to deal with this
> + * is to extend alc_spec.input_mux to allow a different input MUX for each
> + * ADC.  For the purposes of the test model it's sufficient to just list
> + * both options for affected signal indices.  The separate input mux
> + * functionality only needs to be considered if a model comes along which
> + * actually uses signals 0x5, 0x6 and 0x7 for something which makes sense to
> + * record.
> + */
>  static struct hda_input_mux alc260_test_capture_source = {
> -	.num_items = 7,
> +	.num_items = 8,
>  	.items = {
>  		{ "MIC1 pin", 0x0 },
>  		{ "MIC2 pin", 0x1 },
>  		{ "LINE1 pin", 0x2 },
>  		{ "LINE2 pin", 0x3 },
>  		{ "CD pin", 0x4 },
> -		{ "LINE-OUT pin", 0x5 },
> -		{ "HP-OUT pin", 0x6 },
> +		{ "LINE-OUT pin (cap1), Mixer (cap2)", 0x5 },
> +		{ "HP-OUT pin (cap1), LINE-OUT pin (cap2)", 0x6 },
> +		{ "HP-OUT pin (cap2 only) },
>          },
>  };
>  static struct snd_kcontrol_new alc260_test_mixer[] = {
> 



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642

  reply	other threads:[~2006-02-20  5:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060219205100.E38D7885EA@sc8-sf-spam1.sourceforge.net>
2006-02-20  0:17 ` [PATCH] hda/alc260: tweak test model input mux labels, fix a comment Jonathan Woithe
2006-02-20  5:36   ` Rimas Kudelis [this message]
2006-02-20  6:17     ` [PATCH] hda/alc260: tweak test model input mux labels, Jonathan Woithe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43F95548.1000805@akl.lt \
    --to=rq@akl.lt \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=jwoithe@physics.adelaide.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.